Skip to content

Fix failing UI tests: update mistake threshold from 5 to 10 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
usharik merged 1 commit into from
Aug 28, 2026
Merged

Fix failing UI tests: update mistake threshold from 5 to 10 #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions app/src/androidTest/kotlin/com/usharik/app/DeclensionQuizTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class DeclensionQuizTest : BaseComposeTest() {
composeTestRule.onNodeWithTag(TestTags.FULL_WORD).assertIsDisplayed()
composeTestRule.onNodeWithTag(TestTags.FULL_ERROR_COUNTER).assertIsDisplayed()

// Error counter starts at 0/5
assertEquals("0/5", taggedText(TestTags.FULL_ERROR_COUNTER))
// Error counter starts at 0/10
assertEquals("0/10", taggedText(TestTags.FULL_ERROR_COUNTER))
}

/**
Expand Down Expand Up @@ -81,7 +81,7 @@ class DeclensionQuizTest : BaseComposeTest() {
!tagExists("${TestTags.FULL_POOL_WORD_PREFIX}$poolIndex")
}
assertEquals(text, cellText(number = 0, caseIndex = 0))
assertEquals("0/5", taggedText(TestTags.FULL_ERROR_COUNTER))
assertEquals("0/10", taggedText(TestTags.FULL_ERROR_COUNTER))
}

/** A solved cell may be rearranged, but it must never earn its correct-form points twice. */
Expand Down Expand Up @@ -119,7 +119,7 @@ class DeclensionQuizTest : BaseComposeTest() {

dragPoolWordToCell(poolIndex, number = 0, caseIndex = 0)

assertEquals("1/5", taggedText(TestTags.FULL_ERROR_COUNTER))
assertEquals("1/10", taggedText(TestTags.FULL_ERROR_COUNTER))
composeTestRule.waitUntil(timeoutMillis = 3_000) {
tagExists("${TestTags.FULL_POOL_WORD_PREFIX}$poolIndex")
}
Expand Down Expand Up @@ -168,12 +168,12 @@ class DeclensionQuizTest : BaseComposeTest() {
val word = loadedWord()
val (poolIndex, _) = poolFormNotMatchingTarget(word, number = 0, caseIndex = 0)
dragPoolWordToCell(poolIndex, number = 0, caseIndex = 0)
assertEquals("1/5", taggedText(TestTags.FULL_ERROR_COUNTER))
assertEquals("1/10", taggedText(TestTags.FULL_ERROR_COUNTER))

composeTestRule.onNodeWithTag(TestTags.NAV_NEXT_BTN).performClick()

composeTestRule.waitUntil(timeoutMillis = 5_000) { taggedText(TestTags.FULL_ERROR_COUNTER) == "0/5" }
assertEquals("0/5", taggedText(TestTags.FULL_ERROR_COUNTER))
composeTestRule.waitUntil(timeoutMillis = 5_000) { taggedText(TestTags.FULL_ERROR_COUNTER) == "0/10" }
assertEquals("0/10", taggedText(TestTags.FULL_ERROR_COUNTER))
}

/**
Expand Down Expand Up @@ -386,20 +386,20 @@ class DeclensionQuizTest : BaseComposeTest() {
}

/**
* Five wrong placements reach the same limit shown by the error badge, trigger the
* Ten wrong placements reach the same limit shown by the error badge, trigger the
* interstitial policy, and reset the badge once the ad flow completes.
*/
@OptIn(ExperimentalTestApi::class)
@Test
fun fiveMistakesDeductPenaltyPoint() {
fun tenMistakesDeductPenaltyPoint() {
openQuizAndWaitForWord()
val word = loadedWord()
val expectedScore = openQuitDialogAndReadScore() - 1

repeat(5) {
repeat(10) {
val (poolIndex, _) = poolFormNotMatchingTarget(word, number = 0, caseIndex = 0)
dragPoolWordToCell(poolIndex, number = 0, caseIndex = 0)
// The 5th mistake may briefly show a real interstitial ad (if one happened to load),
// The 10th mistake may briefly show a real interstitial ad (if one happened to load),
// pausing the activity, so give this a longer timeout than a plain wrong-drop bounce.
composeTestRule.waitUntil(timeoutMillis = 8_000) {
tagExists("${TestTags.FULL_POOL_WORD_PREFIX}$poolIndex")
Expand All @@ -409,7 +409,7 @@ class DeclensionQuizTest : BaseComposeTest() {
// Wait through the real ad-flow callback rather than blocking the UI thread. Blocking it
// would prevent the delayed threshold handler itself from applying the penalty/reset.
composeTestRule.waitUntil(timeoutMillis = 3_000) {
taggedText(TestTags.FULL_ERROR_COUNTER) == "0/5"
taggedText(TestTags.FULL_ERROR_COUNTER) == "0/10"
}
assertEquals(expectedScore, openQuitDialogAndReadScore())
}
Expand Down