Fix failing UI tests: update mistake threshold from 5 to 10 - #99
Merged
usharik merged 1 commit intoAug 28, 2026
Merged
Conversation
Co-authored-by: usharik <15856751+usharik@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
usharik
August 28, 2026 17:16
View session
usharik
marked this pull request as ready for review
August 28, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing
ui-testsCI job from run #33192407135.Root Cause
The mistake threshold was increased from 5 to 10 in a prior commit, but the UI tests in
DeclensionQuizTest.ktstill hardcoded the old value/5, causing 5 test failures:"0/5"/"1/5"failed because the badge now shows/10fiveMistakesDeductPenaltyPointonly made 5 wrong placements, never reaching the new threshold of 10Changes
"0/5"→"0/10"and"1/5"→"1/10"assertion stringsfiveMistakesDeductPenaltyPoint→tenMistakesDeductPenaltyPointrepeat(5)→repeat(10)to actually trigger the penalty threshold