Skip to content

refactor: remove unused async collector hook (#986) #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TATP-233 merged 1 commit into from
Aug 15, 2026
Merged

refactor: remove unused async collector hook (#986) #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/unilab/algos/torch/appo/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ def _build_learner(self):
)
return learner

def _collector_fn(self, stop_event, **kwargs):
appo_collector_fn(stop_event=stop_event, **kwargs)

def learn(
self,
max_iterations: int = 1500,
Expand Down
3 changes: 0 additions & 3 deletions src/unilab/algos/torch/hora/appo_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,6 @@ def _build_learner(self):
enable_compile=algo_cfg.get("enable_compile", True),
)

def _collector_fn(self, stop_event, **kwargs):
hora_appo_collector_fn(stop_event=stop_event, **kwargs)

def learn(
self,
max_iterations: int = 1500,
Expand Down
4 changes: 0 additions & 4 deletions src/unilab/algos/torch/offpolicy/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import torch

from unilab.algos.torch.common.device import get_env_dims
from unilab.algos.torch.offpolicy.worker import off_policy_collector_fn
from unilab.ipc.async_runner import AsyncRunner
from unilab.logging import OffPolicyLogger
from unilab.training.seed import apply_training_seed
Expand Down Expand Up @@ -195,9 +194,6 @@ def _get_default_device(self) -> str:
def _build_learner(self):
return self.learner

def _collector_fn(self, stop_event, **kwargs):
off_policy_collector_fn(stop_event=stop_event, **kwargs)

@staticmethod
def _sync_logger_replay_counters(logger, replay_buffer) -> None:
logger.log_collector(
Expand Down
3 changes: 0 additions & 3 deletions src/unilab/ipc/async_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ def _get_default_device(self) -> str:
@abstractmethod
def _build_learner(self) -> Any: ...

@abstractmethod
def _collector_fn(self, stop_event: Any, **kwargs) -> None: ...

@abstractmethod
def learn(
self, max_iterations: int, save_interval: int = 50, log_dir: str = "logs"
Expand Down
3 changes: 0 additions & 3 deletions tests/ipc/test_async_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ def _get_default_device(self) -> str:
def _build_learner(self) -> Any:
return None

def _collector_fn(self, stop_event: Any, **kwargs) -> None:
pass

def learn(self, max_iterations: int, save_interval: int = 50, log_dir: str = "logs") -> None:
pass

Expand Down
Loading