Skip to content

refactor: remove unused async collector hook (#986) - #990

Merged
TATP-233 merged 1 commit into
dev/issue-983-code-cleanupfrom
cleanup/issue-986-async-runner-hook
Aug 15, 2026
Merged

refactor: remove unused async collector hook (#986)#990
TATP-233 merged 1 commit into
dev/issue-983-code-cleanupfrom
cleanup/issue-986-async-runner-hook

Conversation

@TATP-233

@TATP-233 TATP-233 commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the unused AsyncRunner._collector_fn abstract hook
  • remove APP, off-policy, and HORA forwarding overrides plus the test stub
  • retain each runner explicit _start_collector(target_fn=...) dispatch unchanged

Validation

  • make test-all passed at 0fcbc2655e80299850e52d20389c132e9fd71959
  • 1654 passed, 27 skipped, 273 deselected, 1 xfailed
  • benchmark smoke: 33/34 module-mode and 34/35 script-mode; MLX-only entries skipped
  • production tree contains no _collector_fn definition or call

Closes #986

@TATP-233
TATP-233 requested a review from caozx1110 as a code owner August 15, 2026 21:42
@TATP-233
TATP-233 merged commit 72e69fe into dev/issue-983-code-cleanup Aug 15, 2026
7 of 12 checks passed
@TATP-233
TATP-233 deleted the cleanup/issue-986-async-runner-hook branch August 16, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant