Skip to content

Fixed artifact handling - #79

Merged
JulianTrommer merged 5 commits into
mainfrom
73-issues-with-artifact-handling-and-mapping-to-python-optuna-package
Jun 25, 2026
Merged

Fixed artifact handling#79
JulianTrommer merged 5 commits into
mainfrom
73-issues-with-artifact-handling-and-mapping-to-python-optuna-package

Conversation

@JulianTrommer

Copy link
Copy Markdown
Member

This PR updates artifact upload/download and metadata lookup behavior:

  • upload_artifact now returns the uploaded artifact ID instead of storing it automatically in trial user attrs.
  • Added set_user_attr so callers can explicitly persist artifact IDs when desired.
  • get_all_artifact_meta(study) now handles multi-trial studies with uneven or missing artifacts.
  • get_all_artifact_meta(study, trial) now supports Julia Trials and raw Python Optuna trial objects.
  • download_artifact now writes to the exact requested file path.

Regression tests were added for returned artifact IDs, explicit user attrs, mixed artifact counts across trials, Python/Julia trial metadata lookup, and exact download paths.

@JulianTrommer JulianTrommer linked an issue Jun 24, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/Optuna.jl 100.00% <ø> (ø)
src/artifacts.jl 97.36% <100.00%> (+1.07%) ⬆️
src/trial.jl 100.00% <100.00%> (ø)
src/utils.jl 90.62% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianTrommer

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2d8814fe4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/artifacts.jl

@JoKircher JoKircher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I approve!

@JulianTrommer
JulianTrommer merged commit 26a70eb into main Jun 25, 2026
9 checks passed
@JulianTrommer
JulianTrommer deleted the 73-issues-with-artifact-handling-and-mapping-to-python-optuna-package branch June 25, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with Artifact handling and mapping to Python Optuna package

2 participants