Graphnetcore dataload compat - #22
Merged
Merged
Conversation
added 8 commits
July 28, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the package up to GraphNetCore v0.4 and adds first-class data-import
converters (VTK and CSV) with a new user guide and a regression-tested suite.
The Documenter build is green and Aqua checks pass.
GraphNetCore v0.4 migration
[sources]).TrainState; parameter updates go throughSetfield.@set!instead of field reassignment.df_stepschema widenedand legacy 2-col checkpoints auto-migrated.
GPUCompilerto~1.9for Reactant/CUDA compatibility.dataset.jl/graph.jl/solve.jl/strategies.jl, the example scripts,and
test_normalizer.jlaccordingly. GPU-verified on both fixtures.Data import (new)
vtk_to_hdf5— converts ParaView / DualSPHysics VTK particle trajectories into thetraining HDF5 layout, one trajectory group per source:
.pvd/.pvtu/.vtu: the wrapper formats are parsed internally (ReadVTK canopen neither), and only leaf
.vtupieces are handed to ReadVTK; empty (0-point)frames are detected and skipped before ReadVTK is called.
.vtk(POLYDATA, e.g. DualSPHysicsPartAll_*.vtk) via a built-inreader — ReadVTK doesn't handle legacy
.vtk.recompute_acc(also automatic when no acceleration field is present), and either auser-provided or auto-generated (
write_meta)meta.json.ReadVTK,LightXML.csv_to_hdf5refactored to share the on-disk writer (_write_trajectory!) with theVTK path so both stay byte-compatible.
Dataset(datafile, metafile, args)constructor(format check used
||where&&was intended).Docs
Dataset, HDF5/JLD2, themeta.jsonschema, CSV, and VTK).ModelConfig,save/load_model_config,update_meta!,visualize_eval) and fixed two README links that broke when the README isreused as the docs home — Documenter now builds with no warnings/errors.
Tests
test/test_converters.jl— CV1–CV11 (43 assertions), wired intoruntests.jl. Fixtures aregenerated on the fly (WriteVTK for leaf
.vtu; hand-written.pvd/.pvtu/empty/legacy.vtk)so the tests exercise our own parsing, empty-frame guard, and legacy reader. Also covers the
csv_to_hdf5round-trip..pvtucollection and a legacy.vtktrajectory (517 particles × 151 frames), both loading through
Dataset/getobs.WriteVTKadded as a test-only dependency.Notes / follow-ups
meta.jsononly estimatesdefault_connectivity_radius— set it explicitlyfor real training.
.vtkhdfreader and guidedmeta.jsoncreation.🤖 Generated with Claude Code