Skip to content

Remove check of feature standard deviations #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
choisant wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove check of feature standard deviations #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7761f6c
Remove unnecessary checks blocking pipeline
choisant Aug 20, 2026
1e78f40
Less aggressive editing
choisant Aug 20, 2026
dc51ce9
Merge branch 'main' into patch-1
afroch Aug 20, 2026
a1c616b
Update changelog.md
choisant Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Add container image documentation and generic Slurm/HTCondor submission scripts with config-driven component enumeration [#160](https://github.com/umami-hep/umami-preprocessing/pull/160)
### [v0.3.2](https://github.com/umami-hep/umami-preprocessing/releases/tag/v0.3.2) (04.08.2026)
- Remove assert check for zero standard deviation on features in normalization step

@afroch afroch Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is placed wrong. I needs to go to the top under latest

@afroch afroch Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs the PR as hyperlink (see the other entries)


- Add new configs for central dataset [#159](https://github.com/umami-hep/umami-preprocessing/pull/159)
- Generalise the framework beyond jets to arbitrary global objects [#156](https://github.com/umami-hep/umami-preprocessing/pull/156)
Expand Down
1 change: 0 additions & 1 deletion upp/stages/normalisation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ def write_norm_dict(self, norm_dict: dict) -> None:
assert not np.isinf(tf["std"]), f"{var} std is not finite"
assert not np.isnan(tf["mean"]), f"{var} mean is nan"
assert not np.isnan(tf["std"]), f"{var} std is nan"
assert tf["std"] != 0, f"{var} std is 0"
Comment thread
choisant marked this conversation as resolved.
with open(self.norm_fname, "w") as file:
yaml.dump(norm_dict, file, sort_keys=False)

Expand Down
Loading