Remove check of feature standard deviations - #162
Open
choisant wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 95.34% 95.33% -0.01%
==========================================
Files 25 25
Lines 2340 2339 -1
==========================================
- Hits 2231 2230 -1
Misses 109 109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
afroch
approved these changes
Aug 20, 2026
afroch
requested changes
Aug 20, 2026
afroch
left a comment
afroch
left a comment
Contributor
There was a problem hiding this comment.
Sorry, approved although there is a change needed
Contributor
Author
Fixed it now! |
choisant
changed the title
afroch
reviewed
Aug 25, 2026
|
|
||
| - Add container image documentation and generic Slurm/HTCondor submission scripts with config-driven component enumeration [#160](https://github.com/umami-hep/umami-preprocessing/pull/160) | ||
| ### [v0.3.2](https://github.com/umami-hep/umami-preprocessing/releases/tag/v0.3.2) (04.08.2026) | ||
| - Remove assert check for zero standard deviation on features in normalization step |
Contributor
There was a problem hiding this comment.
This is placed wrong. I needs to go to the top under latest
Contributor
There was a problem hiding this comment.
It also needs the PR as hyperlink (see the other entries)
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline failed because I had a feature with no variation (std = 0) as my data is split into two separate parts (pileup and HS). I still need this feature as I am running two separate pipelines which will be combined later for a special use-case. Propose to remove this check.
Conformity