Skip to content

fix: abolish perch-beta build and simplify release to universal-only DMG - #8

Merged
tukuyomil032 merged 1 commit into
mainfrom
fix/release-lipo-syntax
Jun 9, 2026
Merged

fix: abolish perch-beta build and simplify release to universal-only DMG#8
tukuyomil032 merged 1 commit into
mainfrom
fix/release-lipo-syntax

Conversation

@tukuyomil032

@tukuyomil032 tukuyomil032 commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Remove lipo thinning, beta rename, arm64/x86_64 split DMGs. Restore v0.2.0-style codesign (--force --deep --sign - --timestamp=none) to fix the prohibitory symbol bug. Pre-release flag now set automatically via contains(tag, 'beta').

Summary by CodeRabbit

  • Chores
    • Updated internal release workflow and build artifact generation process.

Remove lipo thinning, beta rename, arm64/x86_64 split DMGs. Restore v0.2.0-style codesign (--force --deep --sign - --timestamp=none) to fix the prohibitory symbol bug. Pre-release flag now set automatically via contains(tag, 'beta').

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 9, 2026 07:54
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

ウォークスルー

リリースワークフロー .github/workflows/release.yml を簡略化。複数アーキテクチャ別の成果物生成・署名・DMG作成処理を削除し、単一DMG生成フローへ統合。バージョン入力説明、ビルド生成先、署名方式、リリース本文、プレリリース判定ロジックが対応して変更されました。

変更内容

リリースワークフロー簡略化

レイヤー / ファイル 説明
バージョン入力説明と版本解決設定
.github/workflows/release.yml
workflow_dispatch 入力の version 説明文を更新し、ベータ表記例を v0.3.0 or v0.3.0-beta.1 へ変更。Resolve version ステップで出力整理、xcodebuild archive 生成先を build/$APP_NAME.xcarchive に統一。
単一アプリ署名とDMG生成フロー
.github/workflows/release.yml
アーキ別アーカイブ・署名・DMG生成ブロック削除。単一の .app に対して ad-hoc 署名(codesign --force --deep --sign - --timestamp=none)を実施し、署名済みアプリから単一DMG(build/dmg/$APP_NAME-${VERSION}.dmg)生成。
リリース本文とファイル・プレリリース判定
.github/workflows/release.yml
リリース本文からアーキ別ダウンロード情報削除。GitHub リリース作成で添付ファイルを複数DMGから単一DMGへ統一。プレリリース判定を is_beta 出力からタグ内 beta 文字列検出へ変更。

推定コードレビュー努力

🎯 3 (Moderate) | ⏱️ ~20 分

関連の可能性がある PR

  • tukuyomil032/Perch#6: 両PRとも .github/workflows/release.yml のリリース生成フロー内で ad-hoc codesign(署名)ステップの変更を扱うため、署名実装に関連。
  • tukuyomil032/Perch#4: 両PRともリリースワークフロー内の成果物生成方式を、アーキ別処理から単一出力フローへ転換しており、整合性を確認する必要があります。

ポエム

🐰 ワークフロー整えて
複雑さはシンプルに、
アーキ別からDMG一つ
リリースもスムーズに
ぴょんぴょん進む! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed プルリクエストのタイトルはchangesetの主要な変更内容を明確に要約しており、開発者の視点から最も重要な変更を簡潔に表現しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-lipo-syntax

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tukuyomil032
tukuyomil032 merged commit 947a14f into main Jun 9, 2026
5 of 6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions release workflow to ship a single universal macOS DMG and to simplify the release pipeline by removing beta-specific bundle renaming and per-arch DMG artifacts, while also adjusting the ad-hoc signing step to match the previously working signing approach.

Changes:

  • Remove lipo “thinning” and the arm64/x86_64/universal split DMG generation; produce a single universal DMG only.
  • Simplify version handling by dropping explicit is_beta/bundle_name outputs and auto-mark prereleases via contains(tag, 'beta').
  • Switch to a single ad-hoc signing step using codesign --force --deep --sign - --timestamp=none on the archived app bundle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tukuyomil032
tukuyomil032 deleted the fix/release-lipo-syntax branch June 9, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants