fix: revert release workflow to single-job universal build - #11
Merged
Conversation
…tion fails on arm64 runner when ARCHS=x86_64 only FrameworkToolboxMacros is a Swift compiler plugin that runs on the host; separate arch jobs break the macro executable path during archive. Single job with -derivedDataPath gives reliable caching (~4min on cache hit). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to revert from a parallel per-architecture matrix build back to a single-job universal (arm64 + x86_64) archive build, addressing Swift Macro cross-compilation failures and improving DerivedData cache reuse.
Changes:
- Removes the arm64/x86_64 matrix build and artifact upload/download flow in favor of a single
xcodebuild archiveuniversal build. - Adds
-derivedDataPath build/DerivedDataand caches that directory to improve repeat build times. - Updates signing and DMG creation steps to use the
.xcarchiveapp product path directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
+33
| key: ${{ runner.os }}-dd-release-${{ hashFiles('perch.xcodeproj/project.pbxproj', 'perch.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-dd-release-${{ matrix.arch }}- | ||
| ${{ runner.os }}-dd-release- |
Comment on lines
+49
to
52
| - name: Build universal archive | ||
| run: | | ||
| set -o pipefail | ||
| xcodebuild archive \ |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGitHub Actions リリースワークフローをアーキテクチャ別マトリクス駆動の複数ジョブから、ユニバーサル（arm64+x86_64）アーカイブビルドを単一ジョブで実行する構成に統合しました。キャッシュ戦略、ビルド手順、署名対象パス、DMG ステージング出力パスがすべて新しいユニバーサルビルド流れに合わせて更新されています。 Changesリリースワークフロー単一ジョブ化
関連 PR
見積もりレビュー工数🎯 3 (Moderate) | ⏱️ ~20 分 詩
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tukuyomil032
added a commit
that referenced
this pull request
Jun 24, 2026
twoColumnView already shows the large artwork plus full lyrics/track info up top. The second HStack — small waveform + Title — Artist text + music.note.list button — was being painted underneath it and read as a mini-widget stuck inside the expanded card (Image #11), well off from the Image #4 reference. Drop the row entirely so the expanded layout is artwork+lyrics, then progressSection, then controlsSection. The full-lyrics overlay button goes with it; LyricsView is already inline in the main row, so the overlay isn't needed for the common path. showLyricsFullView remains unused for now — clean up in a follow-up if no other entry point appears. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tukuyomil032
added a commit
that referenced
this pull request
Jun 24, 2026
…) in twoColumnView Reverts Fix 6 (60e0cb4). Dropping the HStack made the expanded card look thin and lost the lyrics overlay entry point — Image #11 was missing the waveform band and Title—Artist line that Image #4 expects. Put the row back exactly as it appears on main: WaveformView (real audio capture or synthetic fallback), the truncated Title — Artist label, and the music.note.list button that opens the lyricsFullView when lyrics are loaded. showLyricsFullView is wired again because the button is back; no other call sites changed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARCHS=x86_64のみ指定するとFrameworkToolboxMacros（Swift Compiler Plugin）のアーカイブパスが解決できずにビルドエラー-derivedDataPath build/DerivedDataを追加してキャッシュを確実に効かせるTest Plan
🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート