Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile.QA
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
RUN rm -f /usr/bin/python && \
ln -s /usr/bin/python3 /usr/bin/python

RUN pip3 install --upgrade "numpy<2" pillow attrdict future "grpcio<1.68" requests gsutil \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why notgrpcio>=1.81.1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because none of the other packages were attempting to lower the value.

do you prefer the version to present a minimum value? none of the packages have this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer consistency. Let add the minimum version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

"awscli<=1.36.40" six "grpcio-channelz<1.68" prettytable virtualenv \
RUN pip3 install --upgrade "numpy<2" pillow attrdict future "grpcio>=1.81.1" requests gsutil \
"awscli<=1.36.40" six grpcio-channelz prettytable virtualenv \
check-jsonschema

# go needed for example go client test.
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.sdk
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ RUN apt-get update && \
software-properties-common \
vim \
wget && \
pip3 install --upgrade "grpcio-tools<1.68" cmake==4.0.3 auditwheel
pip3 install --upgrade grpcio-tools cmake==4.0.3 auditwheel

ENV CMAKE_POLICY_MINIMUM_REQUIRED=3.5

Expand Down Expand Up @@ -182,7 +182,7 @@ RUN apt-get update && \
python3-wheel \
vim \
wget && \
pip3 install "grpcio<1.68" "grpcio-tools<1.68" && \
pip3 install "grpcio>=1.81.1" grpcio-tools && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/*;

Expand Down
Loading