Skip to content

maintenance: Update grpcio Dependencies - #8765

Merged
whoisj merged 3 commits into
mainfrom
jwyman/tri-836-update-tritonclients-gprc-package-dependency-version
Jul 16, 2026
Merged

maintenance: Update grpcio Dependencies#8765
whoisj merged 3 commits into
mainfrom
jwyman/tri-836-update-tritonclients-gprc-package-dependency-version

Conversation

@whoisj

@whoisj whoisj commented May 4, 2026

Copy link
Copy Markdown
Contributor

@whoisj

whoisj commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

CI Pipeline ID: 50244177

yinggeh
yinggeh previously approved these changes May 5, 2026
@whoisj
whoisj force-pushed the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch from 5e49fa6 to 06e3f46 Compare May 29, 2026 19:58
@whoisj
whoisj force-pushed the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch 4 times, most recently from 45eabce to 457efe6 Compare June 15, 2026 22:42
yinggeh
yinggeh previously approved these changes Jun 15, 2026
@whoisj
whoisj force-pushed the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch from 457efe6 to abb364f Compare June 26, 2026 17:13
@whoisj
whoisj marked this pull request as draft June 29, 2026 17:14
@whoisj
whoisj force-pushed the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch from abb364f to cdf9687 Compare July 2, 2026 19:16
This change updates the `grpcio` dependencies to `>=1.63.0` and removes the upper bound.
@whoisj
whoisj force-pushed the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch from cdf9687 to 69c5440 Compare July 9, 2026 15:37
@whoisj
whoisj marked this pull request as ready for review July 9, 2026 20:00
Comment thread Dockerfile.QA
RUN rm -f /usr/bin/python && \
ln -s /usr/bin/python3 /usr/bin/python

RUN pip3 install --upgrade "numpy<2" pillow attrdict future "grpcio<1.68" requests gsutil \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why notgrpcio>=1.81.1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because none of the other packages were attempting to lower the value.

do you prefer the version to present a minimum value? none of the packages have this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer consistency. Let add the minimum version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@whoisj
whoisj requested review from mc-nv and yinggeh July 10, 2026 17:27
mc-nv
mc-nv previously approved these changes Jul 10, 2026
@whoisj
whoisj dismissed stale reviews from mc-nv and yinggeh via d1a5760 July 10, 2026 18:29
@whoisj
whoisj requested a review from mc-nv July 10, 2026 18:29
Comment thread Dockerfile.sdk Outdated
Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
@whoisj
whoisj requested a review from yinggeh July 10, 2026 18:33
@yinggeh

yinggeh commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Please use our template for non-trivial PRs. Also add the new related PRs.

@whoisj
whoisj merged commit 194cae4 into main Jul 16, 2026
3 checks passed
@whoisj
whoisj deleted the jwyman/tri-836-update-tritonclients-gprc-package-dependency-version branch July 16, 2026 23:38
pskiran1 added a commit that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants