build(before-code-freeze): Prepare the ONNX Runtime backend for the manylinux base - #352
Open
mc-nv wants to merge 6 commits into
Open
Conversation
This was referenced Aug 5, 2026
Open
Contributor
Author
|
@greptileai review |
Greptile SummaryThe PR updates ONNX Runtime backend image generation for the manylinux-based 26.08 environment.
Confidence Score: 4/5The PR is not yet safe to merge because the previously reported removal of supported historical OpenVINO mappings still causes Dockerfile generation to fail. The current version map still omits releases from 2024.0.0 through 2025.4.1, so selecting one of those previously accepted versions reaches the unchanged direct map lookup and terminates generation with a KeyError. Files Needing Attention: tools/gen_ort_dockerfile.py Important Files Changed
Reviews (2): Last reviewed commit: "adding missed package" | Re-trigger Greptile |
| @@ -34,46 +34,6 @@ | |||
| FLAGS = None | |||
|
|
|||
| OPENVINO_VERSION_MAP = { | |||
There was a problem hiding this comment.
mc-nv
marked this pull request as ready for review
August 5, 2026 23:31
yinggeh
previously approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Prepare the ONNX Runtime backend for the 26.08 manylinux base:
setuptoolsto the RHEL pip list -- ORT's--build_wheelstep runssetup.py bdist_wheelunder the pipx interpreter, and Python 3.12 no longerbootstraps setuptools, so the wheel step failed with
ModuleNotFoundError.onnxruntime_error_code.h, new in ORT 1.28.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
Where should the reviewer start?
tools/gen_ort_dockerfile.py.Test plan:
Covered by the internal RHEL/manylinux pipeline for the 26.08 upstream bump.
Caveats:
onnxruntime_error_code.hexists only from ORT 1.28 (404 atrel-1.27.0, 200 atrel-1.28.0). Any job still pinning ORT 1.27 will fail the header copy -- thenon-RHEL path builds
server@main, which pins 1.27.0 whileserver/build.pydefaults to 1.28.0.
Background
Part of the 26.08 "build against latest upstream container" work: the base image
moved to
cuda:13.4-devel-manylinux--26.08, which changed the default GCCtoolset, the Python layout and the bundled OpenSSL.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Resolves: TRI-1650
CI (internal): [#61271932](http://tritonserver.local/ci/pipelines/61271932)