build(before-code-freeze): Align CMake configuration with the other repos - #162
Open
mc-nv wants to merge 2 commits into
Open
Conversation
This was referenced Aug 5, 2026
Open
Contributor
Author
|
@greptileai review |
Greptile SummaryThe PR aligns protobuf Python code generation with CMake’s
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported Python executable variable mismatch is fixed at the current head. Important Files Changed
Reviews (3): Last reviewed commit: "fix: Use Python3_EXECUTABLE for the gRPC..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
mc-nv
changed the title
cd84eea switched the lookup to find_package(Python3 ...) but left the custom command on ${Python_EXECUTABLE}, which that package never populates. The variable expands to empty, so the grpc_tools.protoc command runs with no interpreter and grpc-service-py-library cannot generate its output. TRITON_COMMON_ENABLE_PROTOBUF_PYTHON defaults to ON, so this is on the default build path rather than an opt-in one. Only Interpreter is requested, which is all the codegen needs.
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Align the CMake configuration with the other Triton repositories.
Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
Where should the reviewer start?
The
CMakeLists.txtdiff.Test plan:
Covered by the internal RHEL/manylinux pipeline for the 26.08 upstream bump.
Caveats:
None known.
Background
Part of the 26.08 "build against latest upstream container" work: the base image
moved to
cuda:13.4-devel-manylinux--26.08, which changed the default GCCtoolset, the Python layout and the bundled OpenSSL.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Resolves: TRI-1650
CI (internal): [#61271932](http://tritonserver.local/ci/pipelines/61271932)