Repository navigation
fix(sandbox): confirm final process disappearance during inventory - #886
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Confirm actual process disappearance after the final procfs status lookup so an exited ordinary build child does not become a false unreadable-VM inventory failure. Live unreadable identities, authorization denials, namespace mismatches and changing VM inventories remain fail-closed.
Work authority
Contributor mode (select one):
Plan
Reproduce narrow boundary first; add final independent proc-directory absence check; retain strict negatives; strengthen existing native public CLI/supervisor inspection and scene bindings; run fresh complete prerequisites/scenes before merge/publication. Existing Actions already runs original native VM custody early; reuse that step.
Changes and commits
Verification
CI prerequisite correction: initial run39390967852 stopped before the changed native cases: held Reviewer108f installed-custody case spent22.93s in INSTALL, exhausted its original25s work budget during PLAN, and reported subprocess residue/closure unproven. Full suites/scenes did not run. Commitef8b3514 adopts checked protected Reviewer001329f305c79beb6c1c8dfb9b85a36c6360e3eb (same tree as checked d42b257; protected38999382684 passed). Its existing owning fix e60ad25 keeps unused UI presentation dependencies out of the production runtime closure; installed-package/cache regression coverage is retained and strengthened. No copied Reviewer code or raised deadlines. Fresh complete run39391832003 is required; prior failed observations remain.
Local:14/14 focused assertions (sandbox-host-inspection and sandbox-vm-custody), strict npm run build and npm run check:source-shape pass. New native integration and complete owner/verifier prerequisites/registered scene evidence remain pending Actions. Local installed runtime differs from candidate bytes, so no local same-candidate native replay is claimed.
Historical protected39387419190 failure is retained: full prerequisites passed, native execution VM custody failed at warm-sandbox-pool.test.ts137:336, later scene steps blocked. Its sanitized receipt does not retain the exact inventory reason. The reproduced race is a real boundary defect; attribution of that historical scene failure remains unproven until fresh native evidence. No blind retry of the failed campaign and no pass credited from the earlier PR receipt.
Risk and rollback
Low scope, strict negative behavior retained. A process directory still present after failed executable/status reads remains an incomplete inventory; permission errors propagate. Existing original process-group and test deadlines are unchanged. Revert8ef0838d via PR if incorrect; do not publish/adopt a failing candidate, alter issued work or remove retained work disks.
Completion summary
Regression and minimum repair committed; full CI/native verification and real readiness acting continuation remain pending. No managed-workday or simulated-release completion claimed.
Submission checklist