Skip to content

Bind generated review readiness to original SDK and approval gates #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianwebb merged 2 commits into from
Oct 12, 2026
Merged

Bind generated review readiness to original SDK and approval gates #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b1464
test(acceptance): reproduce missing generated-review readiness binding
adrianwebb Oct 12, 2026
b8f9697
fix(acceptance): bind generated review readiness to original native g…
adrianwebb Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions guarantees/agent/golden/sdk-complete.guarantee.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ scene:
required: true
manifest: guarantees/agent/golden/scenes/sdk-complete.scene.yaml
acceptanceCriteria:
- criterion: 614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e
verifierRefs: [sdk.golden.live.product, agent.golden.architecture-living-graph-live-1]
- criterion: 8ef82a4f4cb2b8e93d060e38cf8758944d2ba54baca44787811a1d76683f99d4
verifierRefs: [agent.golden.live.campaign-freeze]
- criterion: 2feaea9a8a706e1279affead3af5bacc467f12b285ba2570f183361c5d8203c7
Expand Down
3 changes: 3 additions & 0 deletions tests/modern/guarantees/bindings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ describe('capacity-provider guarantee execution bindings', () => {
.toEqual([{ criterion: '6d6749cd8c2676c6c50c009b55025ec3b951589db602440f63b76ba021159f20', verifierRefs: ['agent.golden.live.graph', product] }]);
expect(refs.filter(value => value === 'agent.golden.live.graph')).toHaveLength(1);
const reviewed = 'agent.golden.architecture-living-graph-live-1';
expect(manifest.acceptanceCriteria.filter((value: { criterion: string }) => value.criterion === '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e'))
.toEqual([{ criterion: '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e', verifierRefs: [product, reviewed] }]);
expect(manifest.acceptanceCriteria.filter((value: { criterion: string }) => value.criterion === '697358e950cb89fc5928569468cd955c25daa8fda7ff97fd1a4af35e2eb95fc6'))
.toEqual([{ criterion: '697358e950cb89fc5928569468cd955c25daa8fda7ff97fd1a4af35e2eb95fc6', verifierRefs: ['agent.golden.live.graph', reviewed] }]);
expect(refs.filter(value => value === reviewed)).toHaveLength(1);
Expand Down Expand Up @@ -195,6 +197,7 @@ describe('capacity-provider guarantee execution bindings', () => {
'b918b519ac545fdd61faab208687ccc64e1f3d03c9a84dfc57a5cfee6190f3f3',
].map(criterion => ({ criterion, verifierRefs: ['agent.golden.live.campaign-freeze'] }));
expect(manifest.acceptanceCriteria).toEqual([
{ criterion: '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e', verifierRefs: ['sdk.golden.live.product', 'agent.golden.architecture-living-graph-live-1'] },
{ criterion: '8ef82a4f4cb2b8e93d060e38cf8758944d2ba54baca44787811a1d76683f99d4', verifierRefs: ['agent.golden.live.campaign-freeze'] },
{ criterion: '2feaea9a8a706e1279affead3af5bacc467f12b285ba2570f183361c5d8203c7', verifierRefs: ['agent.golden.live.campaign-freeze', 'agent.golden.live.campaign'] },
{ criterion: '64ffc06b0d268ad11fbf692ca201cd75423c0afae2a6be3e2ae7cd2eea7fb17f', verifierRefs: ['agent.golden.live.campaign', 'api.golden.execution-normal-sdk-clean-schema-live-1', 'agent.golden.architecture-record-custody-live-1', 'agent.golden.architecture-living-graph-live-1'] },
Expand Down
Loading