Repository navigation
Bind generated review readiness to original SDK and approval gates - #422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Bind selected criterion112 (generated review readiness) to the existing SDK original-proposal/six-pair verifier and Agent exact approved-work-review verifier. These assertions reject authored Reviewer rows, missing/duplicate generated pairs, and downstream admission without the exact independent predecessor approval. Normal SDK scene ordering remains unchanged.
Work authority
614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e.91e3cc9f7c84f97a066c87205c7a26f545360406.b8f9697cbcc138dff2ddb81364bfd06d23d0eebb.Contributor mode (select one):
Plan
Review the complete requirement against existing semantic assertions; commit focused missing-binding RED; repair only selected wiring; run fresh full Agent/executing-Reviewer suites before existing component scenes; inspect actual installed archive and protected staging read-back. Fresh native Actions and actual installed proof passed; criterion112 remains open until ordinary staging delivery and read-back.
Changes and commits
c8b146444d47040a5f469ef28408af3577183d3f: existing registered binding case fails on absent criterion112 mapping (11tests/10passed/1failed/0skipped).b8f9697cbcc138dff2ddb81364bfd06d23d0eebb: exact binding tosdk.golden.live.productandagent.golden.architecture-living-graph-live-1; update the existing exhaustive selected-manifest expectation. No new runner, verifier ID, product behavior, role rule, or scene step.Verification
Node24.12.0; original development authority
e4c4cad1e526f53d3549c8fc27c3e60122b20ee4retained.node node_modules/vitest/vitest.mjs run --config ./vitest.config.ts tests/modern/guarantees/bindings.test.ts tests/modern/kernel/architecture/custody/graph/review-readiness.test.ts tests/modern/kernel/architecture/custody/graph/review-readiness-native.test.ts:16/16passed,0skips/todos. Includes actual disposable Git commits and public SDK/HTTP reads, concurrent exact replay,33missing/foreign/nonapproving/denied/truncated/interrupted cases, retained observations and cleanup.npm run typecheck,npm run check:file-lengths,npm run build:dist:passed.9ecfd240d23df0aa485358b6689eef07ee3662f3, tree9de1a42b727753ff383fa3c8024a35488b61bf39. Independent audit: fresh991Agent+200executing-Reviewer assertions before739component steps; all739independent assertion receipts and118source-file digests match exact Git bytes; zero failures/skips/todos/blocked. Executing Reviewere60ad2581e7ff041f058af04bd810796fea748f9remains held.bf458070c26f5c55d9478c6f13054d2443bc8a3ee0d7a8487571782906b6abe7; scene report SHAdd24293b2fa0a00bb63c5ad29567bcb44237da95a4da63243b1e004bb942df7b. Both official artifact ZIP digests verified; all14checked selected archive assets match source Git.23598622458d7ba138e4b8c4df618016dbaf6796004c0341eb5cf06289b8d3d6;62mapped/142uncovered/204selected/260deferred/464full; only genuine uncovered diagnostics, no stale or missing verifier. Controlled installed inputs establish executable closure and denial behavior; they do not claim actual model/governance execution.Risk and rollback
Wiring-only change; all464identities and deferred obligations retained. No SDK implementation change: genuine simulated Tester/Reviewer/Engineer still owns the retired own-field defect. Revert the two delivery commits by ordinary PR if recovery is needed; preserve original RED/failed observations and existing scene steps.
Completion summary
Focused RED and bounded wiring repair committed; fresh native verification and actual installed archive proof passed. Ready for ordinary staging merge/read-back and scoped branch/dependency cleanup. Checklist credit remains unchanged until delivery. No campaign, release, tag, runtime selection, new worktree or deployment.
Submission checklist