Skip to content

Bind generated review readiness to original SDK and approval gates - #422

Merged
adrianwebb merged 2 commits into
stagingfrom
codex/agent-generated-review-binding-401
Oct 12, 2026
Merged

adrianwebb merged 2 commits into
stagingfrom
codex/agent-generated-review-binding-401

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Bind selected criterion112 (generated review readiness) to the existing SDK original-proposal/six-pair verifier and Agent exact approved-work-review verifier. These assertions reject authored Reviewer rows, missing/duplicate generated pairs, and downstream admission without the exact independent predecessor approval. Normal SDK scene ordering remains unchanged.

Work authority

  • Work item / Issue: Complete capacity-provider and Agent acceptance — continuation of #339 #368 and Continue strict acceptance bindings: current checklist and native reconciliation delivery sdk#401; criterion 614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e.
  • Proposal / decision: Explicit user-authorized strict capacity-provider and agent-execution acceptance implementation plan.
  • Assignment / checkpoint: Integrator-owned selected bindings; existing owning SDK product and Agent review custody assertions.
  • Actor: Codex through provider-authenticated adrianwebb.
  • Human authority: adrianwebb, explicit implementation authorization.
  • Agent / capacity provider: Codex in authorized local workspace.
  • Exact base ref: staging 91e3cc9f7c84f97a066c87205c7a26f545360406.
  • Exact head ref: codex/agent-generated-review-binding-401 b8f9697cbcc138dff2ddb81364bfd06d23d0eebb.

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Review the complete requirement against existing semantic assertions; commit focused missing-binding RED; repair only selected wiring; run fresh full Agent/executing-Reviewer suites before existing component scenes; inspect actual installed archive and protected staging read-back. Fresh native Actions and actual installed proof passed; criterion112 remains open until ordinary staging delivery and read-back.

Changes and commits

  • RED c8b146444d47040a5f469ef28408af3577183d3f: existing registered binding case fails on absent criterion112 mapping (11tests/10passed/1failed/0skipped).
  • Repair b8f9697cbcc138dff2ddb81364bfd06d23d0eebb: exact binding to sdk.golden.live.product and agent.golden.architecture-living-graph-live-1; update the existing exhaustive selected-manifest expectation. No new runner, verifier ID, product behavior, role rule, or scene step.
  • Original proposal validation requires exactly six authored actors and no generated Reviewer rows; public graph read-back requires one exact generated Reviewer per authored row. Original committed Decision read-back requires the exact consumed Actor candidate, assigned independent Reviewer and measured approval interval before downstream admission. Request changes retains history and cannot authorize downstream work.

Verification

Node24.12.0; original development authority e4c4cad1e526f53d3549c8fc27c3e60122b20ee4 retained.

  • Focused original command: node node_modules/vitest/vitest.mjs run --config ./vitest.config.ts tests/modern/guarantees/bindings.test.ts tests/modern/kernel/architecture/custody/graph/review-readiness.test.ts tests/modern/kernel/architecture/custody/graph/review-readiness-native.test.ts:16/16passed,0skips/todos. Includes actual disposable Git commits and public SDK/HTTP reads, concurrent exact replay,33missing/foreign/nonapproving/denied/truncated/interrupted cases, retained observations and cleanup.
  • Initial repair rerun failed the existing exhaustive manifest expectation; retained failure, added the same exact binding to that expectation without relaxing it, then16/16passed.
  • npm run typecheck, npm run check:file-lengths, npm run build:dist:passed.
  • Fresh Verify 38198472954: SUCCESS on proposed merge 9ecfd240d23df0aa485358b6689eef07ee3662f3, tree 9de1a42b727753ff383fa3c8024a35488b61bf39. Independent audit: fresh991Agent+200executing-Reviewer assertions before739component steps; all739independent assertion receipts and118source-file digests match exact Git bytes; zero failures/skips/todos/blocked. Executing Reviewer e60ad2581e7ff041f058af04bd810796fea748f9 remains held.
  • Actual CI archive SHA bf458070c26f5c55d9478c6f13054d2443bc8a3ee0d7a8487571782906b6abe7; scene report SHA dd24293b2fa0a00bb63c5ad29567bcb44237da95a4da63243b1e004bb942df7b. Both official artifact ZIP digests verified; all14checked selected archive assets match source Git.
  • Actual six-owner production install, scripts disabled and sole exact SDK override: all8445owner files match held archive bytes/executable modes. Installed Reviewer productiontsx executes original SDK product guard (positive+22denials) and Agent graph/approved-review guards (positive+3denials); observations retained, no checkout-source runtime fallback. Strict guard typecheck, full production npm dependency inventory and installed CLI public help passed.
  • Source and actual-installed plans agree byte-for-byte: SHA 23598622458d7ba138e4b8c4df618016dbaf6796004c0341eb5cf06289b8d3d6;62mapped/142uncovered/204selected/260deferred/464full; only genuine uncovered diagnostics, no stale or missing verifier. Controlled installed inputs establish executable closure and denial behavior; they do not claim actual model/governance execution.
  • Installation preparation initially used the previous Agent archive because the new CI artifact had not yet been extracted. That attempt and exact commands are retained/uncredited. Correct archive extracted and verified; corrected installation independently reconciles every owner file before execution. Original RED and exhaustive-expectation failure also retained.
  • Managed SDK invocation: blocked by remaining requirements; no passing receipt or launch-readiness claim.

Risk and rollback

Wiring-only change; all464identities and deferred obligations retained. No SDK implementation change: genuine simulated Tester/Reviewer/Engineer still owns the retired own-field defect. Revert the two delivery commits by ordinary PR if recovery is needed; preserve original RED/failed observations and existing scene steps.

Completion summary

Focused RED and bounded wiring repair committed; fresh native verification and actual installed archive proof passed. Ready for ordinary staging merge/read-back and scoped branch/dependency cleanup. Checklist credit remains unchanged until delivery. No campaign, release, tag, runtime selection, new worktree or deployment.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

@adrianwebb
adrianwebb marked this pull request as ready for review October 12, 2026 03:37
@adrianwebb
adrianwebb merged commit 2bfd3d5 into staging Oct 12, 2026
4 checks passed
@adrianwebb
adrianwebb deleted the codex/agent-generated-review-binding-401 branch October 12, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant