Skip to content

Fix the drop_indices helper for ES version portability #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlfonsoUceda merged 2 commits into from
Mar 25, 2026
+8 −3
Merged

Fix the drop_indices helper for ES version portability #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df52b48
Fix the drop_indices helper for ES version portability
mattmenefee Mar 18, 2026
51c17e4
Merge branch 'master' into fix-drop-indices-json-format
AlfonsoUceda Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Changes

* [#1011](https://github.com/toptal/chewy/pull/1011): Replace deprecated `Sidekiq::Testing` API with new `Sidekiq 8.1+` testing API and silence Sidekiq logger during spec runs. ([@mattmenefee][], [@mjankowski][])
* [#1013](https://github.com/toptal/chewy/pull/1013): Fix `drop_indices` test helper to use `format: 'json'` for ES version portability. If you define a custom `drop_indices` helper in your test suite, update it to use `Chewy.client.cat.indices(format: 'json')` instead of parsing the text-format response. ([@mattmenefee][])
* [#1014](https://github.com/toptal/chewy/pull/1014): Improve contributing documentation with development setup instructions, PR workflow, and grammar fixes. ([@mattmenefee][])

## 8.0.1 (2026-03-12)
Expand Down
10 changes: 7 additions & 3 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,14 @@
# }
# )

# Low-level substitute for now-obsolete drop_indices
# Low-level substitute for now-obsolete drop_indices.
# Uses format: 'json' for version-portable parsing.
# System indices (prefixed with '.') are excluded to avoid deleting
# ES-internal indices like .security or .kibana.
def drop_indices
response = Chewy.client.cat.indices
indices = response.body.lines.map { |line| line.split[2] }
indices = Chewy.client.cat.indices(format: 'json')
.map { |entry| entry['index'] }
.reject { |name| name.start_with?('.') }
return if indices.blank?

Chewy.client.indices.delete(index: indices)
Expand Down