Fix the drop_indices helper for ES version portability - #1013
Merged
AlfonsoUceda merged 2 commits intoMar 25, 2026
Conversation
mattmenefee
force-pushed
the
fix-drop-indices-json-format
branch
from
March 18, 2026 16:05
c35d0c8 to
cea243e
Compare
The previous implementation parsed the text-format `cat.indices` response by splitting on whitespace and taking column index [2]. This is brittle — column order can change between ES versions. Switch to `format: 'json'` and extract the `index` key from each entry. Also filter out system indices (prefixed with '.') to avoid deleting ES-internal indices like .security or .kibana.
mattmenefee
force-pushed
the
fix-drop-indices-json-format
branch
from
March 18, 2026 16:05
cea243e to
df52b48
Compare
mattmenefee
changed the title
2 tasks
AlfonsoUceda
approved these changes
Mar 25, 2026
AlfonsoUceda
left a comment
AlfonsoUceda
left a comment
Contributor
There was a problem hiding this comment.
@mattmenefee Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drop_indicestest helper from parsing text-formatcat.indicesoutput to usingformat: 'json', which is stable across ES versions.) to avoid deleting ES-internal indices like.securityor.kibanaTest plan
drop_indiceshelper