Skip to content

fix: use list instead of getBucketInfo for credentials test #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designcode merged 1 commit into from
Apr 7, 2026
Merged

fix: use list instead of getBucketInfo for credentials test #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions src/lib/credentials/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { getStorageConfig } from '@auth/provider.js';
import { getSelectedOrganization } from '@auth/storage.js';
import { getBucketInfo, listBuckets } from '@tigrisdata/storage';
import { getStorageConfigWithOrg } from '@auth/provider.js';
import { list, listBuckets } from '@tigrisdata/storage';
import { exitWithError, failWithError } from '@utils/exit.js';
import {
msg,
Expand All @@ -19,7 +18,7 @@ export default async function test(options: Record<string, unknown>) {

const bucket = getOption<string>(options, ['bucket', 'b']);

const config = await getStorageConfig();
const config = await getStorageConfigWithOrg();

if (!config.accessKeyId && !config.sessionToken) {
failWithError(
Expand All @@ -28,19 +27,11 @@ export default async function test(options: Record<string, unknown>) {
);
}

// Include organization ID if available
const selectedOrg = getSelectedOrganization();
const finalConfig = {
...config,
...(selectedOrg && !config.organizationId
? { organizationId: selectedOrg }
: {}),
};

if (bucket) {
// Test access to specific bucket
const { data, error } = await getBucketInfo(bucket, {
config: finalConfig,
// Test access to specific bucket by listing objects
const { error } = await list({
config: { ...config, bucket },
limit: 1, // just to check if we can list objects
});

if (error) {
Expand All @@ -56,19 +47,15 @@ export default async function test(options: Record<string, unknown>) {
JSON.stringify({
valid: true,
bucket,
...(data.sourceBucketName ? { forkOf: data.sourceBucketName } : {}),
})
);
} else {
console.log(` Bucket: ${bucket}`);
console.log(` Access verified.`);
if (data.sourceBucketName) {
console.log(` Fork of: ${data.sourceBucketName}`);
}
}
} else {
// Test general access by listing buckets
const { data, error } = await listBuckets({ config: finalConfig });
const { data, error } = await listBuckets({ config });

if (error) {
printFailure(context, "Current credentials don't have sufficient access");
Expand Down