Skip to content

fix: use list instead of getBucketInfo for credentials test - #68

Merged
designcode merged 1 commit into
mainfrom
fix/credentials-test-bucket
Apr 7, 2026
Merged

designcode merged 1 commit into
mainfrom
fix/credentials-test-bucket

Conversation

@designcode

@designcode designcode commented Apr 7, 2026 •

Copy link
Copy Markdown
Collaborator

Replaces getBucketInfo with list (ListObjects) for the --bucket flag in credentials test, avoiding the custom HTTP client path.


Note

Low Risk
Low risk CLI behavior change limited to the credentials test command; the main risk is altered permission semantics (bucket validation now requires object listing permission) and slightly different output.

Overview
tigris credentials test now derives its storage config via getStorageConfigWithOrg() (removing the command’s local selected-org merge) and, when --bucket is provided, validates access by issuing a list (ListObjects) with limit: 1 instead of calling getBucketInfo.

This also simplifies output by dropping fork-related fields (sourceBucketName) from both JSON and text responses, while leaving the no---bucket path as a listBuckets check using the updated config.

Reviewed by Cursor Bugbot for commit 9d761b1. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/lib/credentials/test.ts Resolved
@designcode
designcode force-pushed the fix/credentials-test-bucket branch from 979d348 to a65ced8 Compare April 7, 2026 08:26

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a65ced8. Configure here.

Comment thread src/lib/credentials/test.ts Resolved
Replaces getBucketInfo with list (ListObjects) for the --bucket flag
in credentials test, avoiding the custom HTTP client path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@designcode
designcode force-pushed the fix/credentials-test-bucket branch from a65ced8 to 9d761b1 Compare April 7, 2026 08:36
@designcode
designcode merged commit 60662d5 into main Apr 7, 2026
3 checks passed
@designcode
designcode deleted the fix/credentials-test-bucket branch April 7, 2026 08:51
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants