Skip to content

fix: preview cleanup queue deletion + update actions to node24 #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
palmithor merged 1 commit into from
Aug 11, 2026
Merged

fix: preview cleanup queue deletion + update actions to node24 #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ jobs:
fetch-depth: 0

- name: 🥟 Setup Bun
uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest

- name: 📦 Install dependencies
run: bun install

- name: ⚡ Setup Turbo cache
uses: rharkor/caching-for-turbo@cda201ff2b32699a2ae9f59704db029e3dde4fbd
uses: rharkor/caching-for-turbo@2238fae6eb9a9936f92356f54cb3660200d105e7 # v2.5.1

- name: 💅 Format check
run: bun run format
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}

- name: Build & Deploy Worker
uses: cloudflare/wrangler-action@da0e0dfe58b7a431659754fdf3f186c529afbe65 # v3.14.1
uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0
if: github.ref == 'refs/heads/main'
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ jobs:
fetch-depth: 0

- name: 🥟 Setup Bun
uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest

- name: 📦 Install dependencies
run: bun install

- name: ⚡ Setup Turbo cache
uses: rharkor/caching-for-turbo@cda201ff2b32699a2ae9f59704db029e3dde4fbd
uses: rharkor/caching-for-turbo@2238fae6eb9a9936f92356f54cb3660200d105e7 # v2.5.1

- name: 🎭 Install Playwright
run: bunx playwright install chromium --with-deps
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0

- name: 🥟 Setup Bun
uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest

Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}

- name: 🚀 Deploy to Cloudflare Workers
uses: cloudflare/wrangler-action@v3
uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0
id: deploy
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
Expand All @@ -114,7 +114,7 @@ jobs:
echo "preview_url=$PREVIEW_URL" >> $GITHUB_OUTPUT

- name: 💬 Comment on PR
uses: actions/github-script@v7
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
const prNumber = context.issue.number;
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0

- name: 🥟 Setup Bun
uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: latest

Expand All @@ -192,7 +192,7 @@ jobs:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}

- name: 🗑️ Delete Worker
uses: cloudflare/wrangler-action@v3
uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0
continue-on-error: true
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}

- name: 💬 Comment on PR
uses: actions/github-script@v7
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
const prNumber = context.issue.number;
Expand Down
2 changes: 1 addition & 1 deletion scripts/lib/cleanup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export async function deleteQueue(queueName: string): Promise<CleanupResult> {

if (queueExists) {
debug(`Deleting queue ${queueName}...`);
const cmd = $`bun wrangler queues delete ${queueName} --force`;
const cmd = $`bun wrangler queues delete ${queueName}`;

@agent-coding-cowboy agent-coding-cowboy Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing --force may cause wrangler to prompt for confirmation, hanging automated scripts. Should this flag be kept for CI environments?

@palmithor palmithor Aug 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: wrangler queues delete has no confirmation prompt and no --force flag in v4.67.0.

  • wrangler queues delete --help lists only the positional name + global flags — no --force, no --yes, no confirm option.
  • The command source (src/queues/cli/commands/delete.ts) handler calls deleteQueue() → deleteQueueById() directly, which issues a plain DELETE API request. There is no confirmOrPrompt() anywhere in the path, so nothing can hang on a prompt in CI.
  • The original CI failure (Unknown argument: force) proves --force is rejected outright by wrangler — it was never accepted. Keeping it would keep the delete broken; removing it is the fix.

So removing --force is correct and there is no confirmation risk in this wrangler version.

if (!debugMode) {
cmd.quiet();
}
Expand Down
Loading