fix: preview cleanup queue deletion + update actions to node24 - #649
Conversation
wrangler queues delete does not support --force, causing preview cleanup to fail on queue deletion. Remove the invalid flag. Update GitHub Actions that target deprecated Node 20 (setup-bun, wrangler-action, github-script, caching-for-turbo) to node24 versions to eliminate deprecation warnings.
![agent-coding-cowboy[bot]](https://avatars.githubusercontent.com/u/246662916?s=60&v=4){kind=small}
| if (queueExists) { | ||
| debug(`Deleting queue ${queueName}...`); | ||
| const cmd = $`bun wrangler queues delete ${queueName} --force`; | ||
| const cmd = $`bun wrangler queues delete ${queueName}`; |
There was a problem hiding this comment.
Removing --force may cause wrangler to prompt for confirmation, hanging automated scripts. Should this flag be kept for CI environments?
There was a problem hiding this comment.
Verified: wrangler queues delete has no confirmation prompt and no --force flag in v4.67.0.
wrangler queues delete --helplists only the positionalname+ global flags — no--force, no--yes, no confirm option.- The command source (
src/queues/cli/commands/delete.ts) handler callsdeleteQueue()→deleteQueueById()directly, which issues a plainDELETEAPI request. There is noconfirmOrPrompt()anywhere in the path, so nothing can hang on a prompt in CI. - The original CI failure (
Unknown argument: force) proves--forceis rejected outright by wrangler — it was never accepted. Keeping it would keep the delete broken; removing it is the fix.
So removing --force is correct and there is no confirmation risk in this wrangler version.
🎭 E2E Test Results✅ 22 passed | ❌ 0 failed | ⏱️ 71.5s
📊 View HTML Report Last updated: 2026-08-11T13:52:31.717Z |
🚀 Preview Environment DeployedPreview URL: https://scorebrawl-pr-649.coding-cowboys.workers.dev Test Account:
This preview environment will be automatically cleaned up when the PR is closed. |
The concern is technically incorrect. Verified in wrangler v4.67.0 source that 'wrangler queues delete' has no confirmation prompt (handler directly issues a DELETE API call) and no --force flag (that's what caused the original CI error). The --force removal is correct; no code change needed. See thread reply for evidence.
🧹 Preview Environment Cleaned UpThe preview environment, database, R2 bucket, and queue have been deleted. |
1 participant
Summary
wrangler queues deletedoes not support--force, causingUnknown argument: forcein the cleanup job. Removed the invalid flag inscripts/lib/cleanup.ts.oven-sh/setup-bunv2.0.2 → v2.2.0cloudflare/wrangler-actionv3 → v4.0.0actions/github-scriptv7 → v8.0.0rharkor/caching-for-turbo→ v2.5.1Applied across
preview.yml,ci.yml,e2e.yml.Verification
bun oxcandbun typecheckboth pass.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.