Skip to content

Add support for a third address line parameter - #236

Open
leith wants to merge 1 commit into
thephpleague:masterfrom
CodeDruids:address3-support
Open

Add support for a third address line parameter#236
leith wants to merge 1 commit into
thephpleague:masterfrom
CodeDruids:address3-support

Conversation

@leith

@leith leith commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Some payment gateways support an additional address line for more complex addresses. Rather than making additional accessors just for one line of addressing when everything else is supported by the CreditCard object, we can add support here directly.

@kabudu

kabudu commented Dec 10, 2020

Copy link
Copy Markdown

This is very useful!

@judgej

judgej commented Dec 10, 2020

Copy link
Copy Markdown
Member

How would you see this working with existing drivers that would never look at the address3 property? I can see if the driver is aware of it, and the application is aware that the driver is aware of it, if can be used. But for drivers that only use address1 and address2, the application is going to need to merge it into address1 and address2 anyway. Just wondering if there are any thoughts on this.

@leith

leith commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

So in this scenario, the application wants to use address3, it's supported by the gateway, but the driver only supports address1 and address2?

I think the options here are the same as usual with any drivers, you would either fork the driver to add support for address3 and open a PR (this is my preferred approach), or you'd have to put the data into another field, which as you say is likely to be shoehorned into address1 or address2. Or I guess just accept a loss of accuracy in address going to the gateway (which may or may not be an issue depending on the gateway).

@leith

leith commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

The CI tests are failing for a reason unrelated to this branch (they're failing for master as well): #239

Is there anything I can do to help progress this PR?

@leith

leith commented Dec 22, 2020

Copy link
Copy Markdown
Contributor Author

@barryvdh any chance of a review on this one?

@leith

leith commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Had another gateway with the additional address line item requirement and am having to keep using this fork in order to make it play nice. Is there anything I can do to progress this PR?

@leith

leith commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Rebased on latest master to support PHP 8.x, all checks/tests now passing (yay new CI process). 🙌

@leith
leith force-pushed the address3-support branch from 45de1b0 to 4918acd Compare August 7, 2025 01:07
@leith

leith commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Windcave HPP also supports an address3 parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants