Skip to content

Add third address line support - #1

Open
dp-roberts wants to merge 1 commit into
masterfrom
add-third-address-line-support
Open

Add third address line support#1
dp-roberts wants to merge 1 commit into
masterfrom
add-third-address-line-support

Conversation

@dp-roberts

Copy link
Copy Markdown

No description provided.

Comment thread src/Common/CreditCard.php Outdated
@leith

leith commented Feb 13, 2025

Copy link
Copy Markdown
Member

Why is the PR to the fork rather than upstream? The original fork on the CodeDruids org was only made because I was contributing upstream (thephpleague#236) and expected it to be merged without much issue. 🤷

This PR is also missing the CreditCardTest updates from the original PR.

@daneastmond
daneastmond force-pushed the add-third-address-line-support branch from f704e64 to 17af947 Compare June 4, 2025 14:16
@daneastmond
daneastmond force-pushed the add-third-address-line-support branch from c4d2bb7 to b214a28 Compare June 4, 2025 14:30
@daneastmond

daneastmond commented Jun 4, 2025

Copy link
Copy Markdown

Why is the PR to the fork rather than upstream? The original fork on the CodeDruids org was only made because I was contributing upstream (thephpleague#236) and expected it to be merged without much issue. 🤷

It looks like the original pull request is pretty dead on the phpleague site, so as long as our master is kept in sync it seems to make more sense to ref that.

This PR is also missing the CreditCardTest updates from the original PR.

Added in now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants