Fixes #39522 - Fix failing new lint rules - #1043
Open
MariaAga wants to merge 3 commits into
Open
Conversation
MariaAga
force-pushed
the
fix-lint-magic-numbers
branch
from
July 13, 2026 12:11
bbacc8e to
75fa1f1
Compare
MariaAga
changed the title
MariaAga
force-pushed
the
fix-lint-magic-numbers
branch
from
July 14, 2026 13:44
75fa1f1 to
8f6426b
Compare
MariaAga
force-pushed
the
fix-lint-magic-numbers
branch
from
July 21, 2026 14:45
8f6426b to
f96478a
Compare
MariaAga
marked this pull request as ready for review
July 21, 2026 14:45
pondrejk
approved these changes
Jul 22, 2026
adamruzicka
reviewed
Jul 27, 2026
Comment on lines
-44
to
+51
| exitDelay={copied ? 1500 : 600} | ||
| exitDelay={ | ||
| copied | ||
| ? CLIPBOARD_COPIED_EXIT_DELAY_MS | ||
| : CLIPBOARD_DEFAULT_EXIT_DELAY_MS | ||
| } |
Contributor
There was a problem hiding this comment.
Makes me wonder why we have this when foreman itself does not
Member
Author
There was a problem hiding this comment.
we dont have ClipboardCopyButton in foreman itself. I dont remember why we use here this specific component, but in PF ClipboardCopy does add exitDelay to ClipboardCopyButton
adamruzicka
reviewed
Jul 27, 2026
MariaAga
force-pushed
the
fix-lint-magic-numbers
branch
from
July 29, 2026 13:19
f96478a to
3f79aa1
Compare
adamruzicka
reviewed
Jul 29, 2026
Comment on lines
+85
to
+87
| export const SECONDS_PER_MINUTE = 60; | ||
| export const MINUTES_IN_HOUR = 60; | ||
| export const DAYS_IN_WEEK = 7; |
Contributor
There was a problem hiding this comment.
I was hoping more of those would be defined in core and reused, especially considering those will be needed in other plugins as well
MariaAga
force-pushed
the
fix-lint-magic-numbers
branch
from
July 30, 2026 12:21
8ebaff5 to
e54863d
Compare
Member
Author
|
depends on theforeman/foreman#11120 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for theforeman/foreman#11008 theforeman/foreman#11098 theforeman/foreman#10968