Refs #39253 - perf 1/4 - Add explicit polling to host table - #1047
Open
adamruzicka wants to merge 2 commits into
Open
Refs #39253 - perf 1/4 - Add explicit polling to host table#1047adamruzicka wants to merge 2 commits into
adamruzicka wants to merge 2 commits into
Conversation
1 task
adamruzicka
changed the title
adamlazik1
reviewed
Jul 27, 2026
| if (!jobFinishedRef.current) { | ||
| pollTimeoutId.current = setTimeout( | ||
| () => makeApiCall(currentPollParams.current), | ||
| 5000 |
Contributor
There was a problem hiding this comment.
Generally LGTM, this failed lint needs to be addressed.
Closed
The host table previously relied on an accidental refresh cascade: parent polling updated Redux state, which changed callback identities, which triggered useEffect, which re-fetched hosts. This adds an explicit setTimeout-based polling chain (5s interval) that stops when the job finishes or on API error, and restarts when filters change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host table previously relied on an accidental refresh cascade: parent polling updated Redux state, which changed callback identities, which triggered useEffect, which re-fetched hosts. This adds an explicit setTimeout-based polling chain (5s interval) that stops when the job finishes or on API error, and restarts when filters change.
Requires: