Fixes #39545 - add test:core_tests for plugins to use

[evgeni]

No description provided.

[ekohl]

Should we document this in the developer docs? https://github.com/theforeman/foreman/blob/develop/developer_docs/plugins.asciidoc is probably a good place. Also a chance to show an example for a plugin to override the pattern.

[evgeni]

Also a chance to show an example for a plugin to override the pattern.

How would a plugin override the pattern?

[ekohl]

Good question. I think a plugin can redefine the job, but it's not a very nice way.

[evgeni]

If two plugins are installed, which override wins? I'd rather not go that route.
In theforeman/actions#91 I only implemented "opt-out".
If the need to override arises, we can add it there.

[ekohl]

If two plugins are installed, which override wins? I'd rather not go that route.

Agreed.

I think there is value in plugins being able to extend the list, but perhaps it's good enough to document it exists and that right now it can't be extended.

[ekohl]

Suggested change

	This is executed automatically by the shared GitHub workflow in `@theforeman/actions`.
	This is executed automatically by the shared GitHub workflow in [@theforeman/actions](https://github.com/theforeman/actions).

[ekohl]

Suggested change

	To ensure plugins don't break core functionaly, you can run `rake test:core_tests` which will execute a small set of tests from Foreman core.
	To ensure plugins don't break core functionality, you can run `rake test:core_tests` which will execute a small set of tests from Foreman core.

[ekohl]

Suggested change

	## Using tests from core
	## Testing for regressions in core

[ekohl]

Bikeshedding: should this be test:core?

Suggested change

	Rake::TestTask.new(:core_tests) do |t|
	Rake::TestTask.new(:core) do |t|

[evgeni]

You approved the actions PR with core_tests, so no? ;)

No, really, I don't care too much. Either works.

[ekohl]

I realized it too late. I don't feel too strongly about it though.

[evgeni]

@nadjaheitmann wanna play tiebreaker?