Run a predefined set of tests from core to ensure integration - #91
Merged
Conversation
|
Pipeline is green, I guess this is good somehow :) |
| if: ${{ contains(matrix.task, 'nulldb') }} | ||
| - name: Run rake ${{ matrix.task }} | ||
| run: bundle exec rake ${{ matrix.task }} | ||
| - name: Run extra core tests |
There was a problem hiding this comment.
As it is only one test, I would prefer to name it explicitly
Suggested change
| - name: Run extra core tests | |
| - name: Run access_permissions test from Foreman core |
Member
Author
There was a problem hiding this comment.
Is this still valid, given we're aiming for rake test:core_tests as the default?
|
@evgeni Any plans to continue with this? |
evgeni
marked this pull request as ready for review
June 26, 2026 08:55
Member
Author
|
Yes and no. I still think this is the wrong place to define what needs to be added from core (as IMHO core should be dictating it). I'll post a RFC to the forum and merge this if noone comes up with a better solution. |
evgeni
force-pushed
the
access_permissions_test
branch
from
July 21, 2026 07:20
968589d to
e512846
Compare
evgeni
changed the title
Member
Author
|
And here is the core implementation for 5.0+: theforeman/foreman#11112 |
ekohl
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.