Repository navigation
fix(network): stop capping the package manager's sockets at 15 by default - #10782
Merged
zkochan merged 2 commits intoOct 9, 2026
Merged
Conversation
…ault `Http.getNetworkConfig()` filled in `maxSockets: 15` when `network.max_sockets` was unset, and that value reached the pnpm engine through the dependency resolver's network config. The Rust engine applies `maxSockets` as a hard per-registry limit on in-flight requests, so every install downloaded through at most 15 connections to the registry. The network config now leaves `maxSockets` unset unless the user configured it, as it already does for `networkConcurrency`, and the engine applies its own default. Bit's own HTTP agent keeps the default of 15, applied where the agent is built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Summary by QodoStop capping package-manager downloads at 15 sockets by default
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all |
GiladShoham
approved these changes
Oct 9, 2026
|
Code review by qodo was updated up to the latest commit 15d44f2 |
zkochan
added a commit
that referenced
this pull request
Oct 10, 2026
## Proposed Changes - Bumps `@pnpm/napi` to 12.11.1, which ships pnpm/pnpm#16783: an install with `enableModulesDir: false` fetches the registry packages the host can install into the store while still writing no `node_modules`, as pnpm v10 did. - fusepm installs that way and mounts `node_modules` from the store. With 12.11.0 nothing was fetched, so the FUSE daemon downloaded every package on first access: in the ripple container, compiling a component whose capsule has about 5,500 dependencies took 3 minutes instead of 8 seconds. - Related: #10782, which stops capping the engine at 15 sockets per registry, is needed to match the previous image's overall sign time. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Http.getNetworkConfig()no longer fills inmaxSockets: 15whennetwork.max_socketsis unset. The value reached the pnpm engine through the dependency resolver's network config, and the Rust engine appliesmaxSocketsas a hard per-registry limit on in-flight requests, so every install downloaded through at most 15 connections to the registry. With the setting unset, the engine now applies its own default (64 to 96 connections, by CPU count). This mirrors the existing treatment ofnetworkConcurrencya few lines below.Http.getAgentapplies it through a smallwithAgentSocketDefaulthelper, with a spec.node-registry.bit.cloud: the capsule's install went from 142 s to 71 s, and the whole sign up to the first build task from 5 min 03 s to 4 min 16 s. The same sign on the previous image, with Bit 1.13.226 and pnpm v10, took 4 min 25 s. The old engine had the same 15-socket cap, but its downloads overlapped resolution closely enough to hide it.🤖 Generated with Claude Code