Skip to content

chore(deps): bump @pnpm/napi to 12.11.2 - #10783

Merged
zkochan merged 4 commits into
teambit:masterfrom
zkochan:deps/pnpm-napi-12.11.1
Oct 10, 2026
Merged

zkochan merged 4 commits into
teambit:masterfrom
zkochan:deps/pnpm-napi-12.11.1

Conversation

@zkochan

@zkochan zkochan commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

🤖 Generated with Claude Code

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Bump @pnpm/napi to 12.11.1 to restore store prefetching

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Pin @pnpm/napi 12.11.1 to restore package fetching during installs without node_modules.
• Refresh lockfile entries and platform binaries so fusepm can mount packages from the populated
 store.
Diagram

graph TD
  A["Version pin"] --> B["pnpm install"] --> C[("Package store")] --> D["FUSE mount"] --> E["Component build"]
Loading
High-Level Assessment

Taking the targeted upstream fix and updating its lockfile resolutions is preferable to changing fusepm's install flow or relying on first-access downloads. The diff includes no application-code changes or tests.

Files changed (2) +77 / -77

Other (2) +77 / -77
workspace.jsoncPin @pnpm/napi to 12.11.1 +1/-1

Pin @pnpm/napi to 12.11.1

• Updates the workspace dependency from 12.11.0 to 12.11.1 to pick up the fix for store fetching when enableModulesDir is false.

workspace.jsonc

pnpm-lock.yamlResolve pnpm binding and native binaries at 12.11.1 +76/-76

Resolve pnpm binding and native binaries at 12.11.1

• Updates importer and snapshot references, package integrity hashes, and optional platform-specific @pnpm/napi binaries to match the new pin. No unrelated dependency changes appear in the patch.

pnpm-lock.yaml

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Command-bar tests fail under Chai 5 ⊘ Outdated
Description
The command-bar test statically imports Chai, but the resolved workspace peer is now chai@5.2.1
while the repository’s Mocha/Babel setup transforms test modules to CommonJS. Running the component
test therefore attempts to load Chai 5 with require() and fails before the assertions execute.
Code

pnpm-lock.yaml[58924]

+      chai: 5.2.1
Evidence
The changed lockfile adds a command-bar importer dependency on chai@5.2.1 and a matching
peer-resolved snapshot. The command-bar test uses a static Chai import, while the repository’s test
bootstrap and Babel configuration explicitly transform TypeScript test modules to CommonJS; the
workspace policy otherwise pins Chai to 4.3.0.

pnpm-lock.yaml[19014-19016]
pnpm-lock.yaml[58909-58924]
scopes/explorer/command-bar/command-bar.ui.runtime.spec.tsx[1-1]
babel-register.js[1-9]
babel.e2e.config.js[13-28]
workspace.jsonc[449-453]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The lockfile resolves the command-bar component’s Chai peer to `5.2.1`, but its test is transformed to CommonJS and statically imports Chai, so the test runner cannot load the ESM-only Chai 5 package.
## Fix Focus Areas
- pnpm-lock.yaml[19014-19016]
- pnpm-lock.yaml[58909-58924]
- scopes/explorer/command-bar/command-bar.ui.runtime.spec.tsx[1-1]
- babel.e2e.config.js[13-28]
## Recommended Fix
Regenerate the lockfile so the command-bar importer and its snapshots resolve `chai@4.3.0`, matching the workspace policy and the CommonJS test runner. If Chai 5 is required, instead migrate this test path to an ESM-compatible runner and verify all affected component tests.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@zkochan
zkochan enabled auto-merge (squash) October 9, 2026 13:32
zkochan and others added 2 commits October 9, 2026 19:39
The release makes `enableModulesDir: false` installs fetch the registry
packages the host can install into the store while still writing no
`node_modules`, as pnpm v10 did. fusepm installs that way and mounts
`node_modules` from the store; with 12.11.0 the store stayed empty, and
the FUSE daemon downloaded each package on first access during builds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12.11.2 ships pnpm/pnpm#16797: an install with enableModulesDir: false
also fetches the packages it reuses from an existing lockfile, not only
the ones it resolves.

The lockfile also records command-bar's chai dependency, which teambit#10771
added without updating it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zkochan
zkochan force-pushed the deps/pnpm-napi-12.11.1 branch from f49dc57 to b14dacd Compare October 9, 2026 17:41
@zkochan zkochan changed the title chore(deps): bump @pnpm/napi to 12.11.1 chore(deps): bump @pnpm/napi to 12.11.2 Oct 9, 2026
Comment thread pnpm-lock.yaml
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit b14dacd

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 55108a2

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 04b29a3

@zkochan
zkochan merged commit 47767ee into teambit:master Oct 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants