Fix some build system issues

.github/workflows/compile.yml

@@ -0,0 +1,20 @@
+name: Compile
+
+on:
+  push
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout sources
+      uses: actions/checkout@v5
+    - name: Setup Java
+      uses: actions/setup-java@v4
+      with:
+        distribution: 'temurin'
+        java-version: 8
+    - name: Setup Gradle
+      uses: gradle/actions/setup-gradle@v4
+    - name: Build with Gradle
+      run: ./gradlew build

AdditionalPipesBC_Client.launch

@@ -1 +1 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?><launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication"><stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="GradleStart"/><stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="AdditionalPipesBC"/><stringAttribute key="org.eclipse.jdt.launching.WORKING_DIRECTORY" value="C:\Users\jamie\workspace\AdditionalPipesBC\minecraft"/><stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value=" -DFORGE_FORCE_FRAME_RECALC=true"/></launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?><launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication"><stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="GradleStart"/><stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="AdditionalPipesBC"/><stringAttribute key="org.eclipse.jdt.launching.WORKING_DIRECTORY" value="J:\Minecraft\AdditionalPipesBC\minecraft"/><stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value=" -DFORGE_FORCE_FRAME_RECALC=true"/></launchConfiguration>

AdditionalPipesBC_Server.launch

@@ -1 +1 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?><launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication"><stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="GradleStartServer"/><stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="AdditionalPipesBC"/><stringAttribute key="org.eclipse.jdt.launching.WORKING_DIRECTORY" value="C:\Users\jamie\workspace\AdditionalPipesBC\minecraft"/><stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value=" -DFORGE_FORCE_FRAME_RECALC=true"/></launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?><launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication"><stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="GradleStartServer"/><stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="AdditionalPipesBC"/><stringAttribute key="org.eclipse.jdt.launching.WORKING_DIRECTORY" value="J:\Minecraft\AdditionalPipesBC\minecraft"/><stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value=" -DFORGE_FORCE_FRAME_RECALC=true"/></launchConfiguration>

README.md

@@ -4,36 +4,40 @@
 Click the releases tab at the top.
 
 ### Mod Documentation
+[Current CurseForge page is here](https://www.curseforge.com/minecraft/mc-mods/additional-pipes-for-buildcraft).
+
 [an archived version of the forum thread is here](https://web.archive.org/web/20150919105906/http://mod-buildcraft.com/forums/showthread.php?tid=1467).
 
 ### Cloning and Compiling ###
-First, install [Gradle](https://gradle.org/) and put it on your path.
+
+Note that you will need JDK 8 as this mod (still) targets Minecraft 1.12. You can download that [here](https://www.openlogic.com/openjdk-downloads).
+
+Also note that you will need gradle 6.x, not older or newer. Gradle 6.8 will be used automatically if you use the `gradlew` script.
 
     git clone https://github.com/tcooc/AdditionalPipesBC.git
     cd AdditionalPipesBC
-    gradle setupDecompWorkspace
-    gradle build
+    gradlew setupDecompWorkspace
+    gradlew build
 Compiled binaries can be found in `build/libs`.
+
 
 ### Setting Up Eclipse ###
 1. Install Eclipse JDK.
-2. Run the command `gradle setupDecompWorkspace --refresh-dependencies eclipse`
+2. Run the command `gradlew setupDecompWorkspace --refresh-dependencies eclipse`
 3. In Eclipse, go to `File > Import... > General > Existing Projects into Workspace`
 4. Hit Next.  Click Browse... in the top right, and select the directory you cloned Additional Pipes into.  Check the box next to AdditionalPipesBC in the Projects list.
 5. Hit Finish, and the mod project should be imported.
 6. Set up the run configuration.  Go to `File > Import... > Run/Debug > Launch Configurations` and hit next.
-7. Click the Browse... button and select the directory you cloned Additional Pipes into.  Check the box next to `AP Client 1.8.launch` in the right pane.
+7. Click the Browse... button and select the directory you cloned Additional Pipes into.  Check the box next to `AdditionalPipesBC_Client.launch` and `AdditionalPipesBC_Server.launch` in the right pane.
 8. Hit finish.
 9. Click the down arrow next to the play button on the top bar, select `Run Configurations...`, and click on AP Client 1.8 in the left pane.
-10. Click on `AP Client 1.8` in the left pane and go to the arguments tab.
-11. Replace `<username>` with your Mojang account email, and `<password>` with your Mojang account password
+10. Click on `AdditionalPipesBC_Client` in the left pane and go to the arguments tab.
+11. Replace `<username>` with your Minecraft username.
 11.  Hit run.  If it works, you're done!
 12.  If it doesn't, it's probably because your `.gradle` folder is not in your home directory, or you have unusual environment variables defined.  Either way, in the Arguments tab, replace `${env_var:userprofile}${env_var:HOME}/.gradle` with the full path to the folder containing your `.gradle` folder.
 
 *Done!*
 
-*Look ma, no LWJGL native library errors!*  
-
 ### Download: [latest releases](https://github.com/tcooc/AdditionalPipesBC/releases) ####
 To install, place in the standard minecraft/mods folder.
 

build.gradle

@@ -1,13 +1,15 @@
 buildscript {
     repositories {
-        jcenter()
+        mavenCentral()
         maven {
             name = "forge"
             url = "http://files.minecraftforge.net/maven"
         }
     }
     dependencies {
-        classpath 'net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT'
+        classpath("com.anatawa12.forge:ForgeGradle:2.3-1.0.+") {
+            changing = true
+        }
     }
 }
 apply plugin: 'net.minecraftforge.gradle.forge'
@@ -24,10 +26,8 @@ minecraft {
 }
 // http://maven.apache.org/guides/mini/guide-naming-conventions.html
 repositories {
-	ivy {
-		name "BuildCraft"
-		artifactPattern "http://www.mod-buildcraft.com/releases/BuildCraft/[revision]/[module]-main-[revision]-[classifier].[ext]"
-	}
+
+	mavenCentral()
 	maven 
 	{
 		// location of the maven that hosts JEI files
@@ -40,10 +40,21 @@ repositories {
     	name = "ModMaven"
     	url = "modmaven.k-4u.nl"
 	}
+
+	// Adding a "fake" ivy repository to allow downloading buildcraft from its URL
+	// See https://stackoverflow.com/a/34327202/7083698
+	ivy {
+		url 'http://www.mod-buildcraft.com/releases/'
+		patternLayout {
+			artifact "[organization]/[revision]/[module]-main-[revision]-[classifier].jar"
+		}
+		metadataSources { artifact() } 
+	}
+
 }
 
 dependencies {
-	compile name: 'buildcraft', version: "7.99.24.1", classifier: "dev", ext: 'jar'
+	compile 'BuildCraft:buildcraft:7.99.24.1:dev'
 
 	// compile against the JEI API but do not include it at runtime
 	deobfProvided "mezz.jei:jei_${mc_version}:${jei_version}:api"
@@ -93,3 +104,11 @@ task deobfJar(type: Jar) {
     from sourceSets.main.output
     classifier = 'dev'
 }
+
+// Download source jars for Eclipse
+eclipse {
+    classpath {
+        downloadJavadoc = true
+        downloadSources = true
+    }
+}

gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.0-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.1-bin.zip