lastlogin for dev mode - #775
Open
tarasglek wants to merge 13 commits into
Open
Conversation
Deploying chatcraft-org with
|
| Latest commit: |
c18edb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8cf01ecc.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://taras-lastlogin.console-overthinker-dev.pages.dev |
Owner
Author
|
@humphd it's neither here nor there. https://jsr.io/@pomdtr/lastlogin solves as many problems as it introduces, but I think it would be a great student project to make it into a generic oauth lib for us. Most of the code is hacks to deal with integrating this lib into our existing codebase. Overall quality of our auth code is heavy on copy-pasta, a little terrifying tho I found no bugs yet However overall safety and ergonomics of this style of fetch wrapper are kind of amazing compared to alternatives |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a lot more minimal than our auth in terms of effort. I'm 99% sure that lastlogin lib is just generic oauth that needs to be generalized a little, so it can support google/github directly