Skip to content

this lastlogin wrapper is fantastic for net new code, for more complex usecases it has potential #2

Description

@tarasglek

I tried to integrate into chatcraft and things got sad fast. My hacks are at tarasglek/chatcraft.org#775

Overall I like the wrapper approach of lastlogin a lot better. However integrating lastlogin alongside direct oauth implementations for google/github had the following issues

  1. Would be good to override lastlogin_jwt cookie name or atleast have it exported
  2. Would be good to over-ride _auth/callback. Ideally i'd be able to set it to my /api/login route and have your lib match it by something like req.pathname == custom_callback && OAUTH_COOKIE is present && code param is set...so we reuse same route for request protected by lastlogin and lastlogin oauth flow
  3. Would be good to get other fields out of lastlogin like avatar, username
  4. Once we have above 1-3, then it would be cool to make this lib a generic oauth lib. It's so much better than any other auth lib i've seen.

Out of this list only 1, 2 are hurting me badly atm.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions