migrate HTTP to v2 - #27
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 50.45% 45.86% -4.60%
==========================================
Files 1 1
Lines 109 133 +24
==========================================
+ Hits 55 61 +6
- Misses 54 72 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
There are strange failures, which might be time related as HTTP precompilation has a timeout as far as I have understood (JuliaWeb/HTTP.jl#1252). |
|
Looks like with these changes the lower bound for supported Julia version becomes 1.10. And we would need to drop x86 support. I am fine with that. I'll try and add some commits here in a bit and see if the tests pass. |
- Raise julia compat to 1.10 (required by HTTP 2.1.1 / Reseau 1.2.1) and drop Julia 1.0 plus all x86 CI jobs (Reseau has no 32-bit support). - Fix OIDCCtx construction throwing when verify=false is combined with a custom cacrt: HTTP v2 rejects require_ssl_verification overrides on an explicit Client, so carry the verify intent via the TLS.Config instead. - Document the narrowed cacrt contract (file path only) and bump version to 0.2.0 for the breaking API change. - Add a Custom CA certificate testset covering the cacrt path, the verify=false regression, and the bad-path error.
|
Cool! I think it is, indeed, a good idea for a security app to use the state of the art http stack. MbedTLS is known to be vulnerable. |
|
@hhaensel could you please check and merge hhaensel#2 ? |
Fix CI for HTTP v2 migration: julia compat, x86/1.0 matrix, and verify+cacrt bug
|
Thanks for reviewing, looks good! |
3 participants
The new HTTP v2 skips support for MbedTLS, so we need to go to TLS instead