Fix CI for HTTP v2 migration: julia compat, x86/1.0 matrix, and verify+cacrt bug - #2
Merged
Merged
Conversation
- Raise julia compat to 1.10 (required by HTTP 2.1.1 / Reseau 1.2.1) and drop Julia 1.0 plus all x86 CI jobs (Reseau has no 32-bit support). - Fix OIDCCtx construction throwing when verify=false is combined with a custom cacrt: HTTP v2 rejects require_ssl_verification overrides on an explicit Client, so carry the verify intent via the TLS.Config instead. - Document the narrowed cacrt contract (file path only) and bump version to 0.2.0 for the breaking API change. - Add a Custom CA certificate testset covering the cacrt path, the verify=false regression, and the bad-path error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the HTTP v2 migration (tanmaykm#27), targeting your
hh-http-v2branch so the fixes land in that PR.CI failures addressed
1. Julia 1.0 jobs (
EnumXunsatisfiable) — the PR pinnedHTTP = "2.1.1"but leftjulia = "1". HTTP 2.1.1 and Reseau 1.2.1 both declarejulia = "1.10", so 1.0 can never resolve. Raised[compat] juliato1.10and dropped1.0from the CI matrix.2. All x86 jobs — Reseau (HTTP v2 TLS backend) has no 32-bit support. Linux x86 fails precompiling with
TLS precompile workload observed an unexpected resumed state; Windows x86 fails withReadOnlyMemoryError(). Removed allx86rows. This makes dropping 32-bit support explicit — flagging it as a maintainer-visible consequence of the migration.Correctness fix
OIDCCtx(...; verify=false, cacrt=<file>)threwArgumentError: require_ssl_verification overrides are not supported when passing an explicit Client. When a custom CA is supplied the code builds an explicitHTTP.Client, and HTTP v2 rejects arequire_ssl_verificationoverride alongside that client. Fix: carry the verify intent through theTLS.Config(verify_peer/verify_hostname) and only setrequire_ssl_verificationin the no-custom-CA path.Other
0.1.8→0.2.0(thecacrtchange is breaking: PEM string contents andMbedTLS.CRTare no longer accepted, file path only).README.mdcacrtdocs to the file-path-only contract.Custom CA certificatetestset covering the cacrt path, theverify=falseregression, and the bad-path error.Tests pass locally (x64 / Julia 1.12):
OpenIDConnect | 34 34 pass. Note the new cacrt tests make real network calls toaccounts.google.com, consistent with the existing suite.