Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/buf-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,19 @@ name: Buf CI
on:
push:
branches: ['**']
# Only top-level release tags (vX.Y.Z[-suffix]) should be synced to BSR.
# Submodule tags such as `cmd/tableauc/vX.Y.Z` (consumed by release.yml)
# must NOT trigger this workflow, otherwise buf-action would push them
# to BSR as well.
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'
- 'v[0-9]+.[0-9]+.[0-9]+-*'
pull_request:
types: [opened, synchronize, reopened, labeled, unlabeled]
delete:
jobs:
buf:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: bufbuild/buf-action@v1
- name: Checkout Code
uses: actions/checkout@v6

- name: Buf CI
uses: bufbuild/buf-action@v1
with:
version: "1.69.0"
version: 1.69.0
token: ${{ secrets.BUF_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Install Buf
uses: bufbuild/buf-action@v1
with:
version: 1.67.0
version: 1.69.0
setup_only: true
github_token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ on:

jobs:
release:
name: Release cmd/tableauc
name: Release tableauc
runs-on: ubuntu-latest
if: startsWith(github.event.release.tag_name, 'cmd/tableauc/')
# Only run for top-level release tags like `vX.Y.Z` (optionally with a suffix).
if: startsWith(github.event.release.tag_name, 'v')
strategy:
matrix:
goos: [linux, darwin, windows]
Expand All @@ -30,9 +31,7 @@ jobs:
go-version: "1.24.x"

- name: Download dependencies
run: |
cd cmd/tableauc
go mod download
run: go mod download

- name: Prepare build directory
run: |
Expand All @@ -52,9 +51,11 @@ jobs:
- name: Create package
id: package
run: |
PACKAGE_NAME=tableauc.${GITHUB_REF#refs/tags/cmd/tableauc/}.${{ matrix.goos }}.${{ matrix.goarch }}.tar.gz
# Strip the leading `refs/tags/` so that a tag like `v0.16.1`
# produces a package name `tableauc.v0.16.1.<goos>.<goarch>.tar.gz`.
PACKAGE_NAME=tableauc.${GITHUB_REF#refs/tags/}.${{ matrix.goos }}.${{ matrix.goarch }}.tar.gz

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT change the PACKAGE_NAME, keep it compatible and the cmd/tableauc path is good, mabye more cmds are developed in the future.

Revert it to: GITHUB_REF#refs/tags/cmd/tableauc/

Refer to https://github.com/tableauio/tableau/releases/tag/cmd%2Ftableauc%2Fv0.16.1

Image

@Kybxd Kybxd Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to do this. cmd%2Ftableauc%2FvX.Y.Z is tag name not package name, but we just want to deprecate cmd/tableauc/vX.Y.Z tags in this pr.

tar -czvf $PACKAGE_NAME -C build .
echo ::set-output name=name::${PACKAGE_NAME}
echo "name=${PACKAGE_NAME}" >> $GITHUB_OUTPUT

- name: Upload asset
uses: actions/upload-release-asset@v1
Expand Down
6 changes: 3 additions & 3 deletions proto/tableau/protobuf/tableau.proto
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,11 @@ message WorksheetOptions {
// Different kvs must be seperated by ',' and one key value must be seperated
// by ':'. If one key doesn't exist in map, it means that this loader option
// is supported in all languages. Valid values are all combinations of "cpp",
// "go" and "csharp" with ' ' as seperator.
// "go", "csharp" and "ts" with ' ' as seperator.
//
// Examples:
// - OrderedMap:cpp,Index:cpp go // ordered map supported in cpp, index
// supported in cpp and go
// - OrderedMap:cpp,Index:cpp go ts // ordered map supported in cpp, index
// supported in cpp, go and ts
// - OrderedMap:cpp // ordered map supported in cpp, index supported in all
// languages
map<string, string> lang_options = 52;
Expand Down
6 changes: 3 additions & 3 deletions proto/tableaupb/tableau.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading