Skip to content

fix: do not paginate columns when listing materialized views #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsusul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not paginate columns when listing materialized views #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/PostgresMetaMaterializedViews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const generateEnrichedMaterializedViewsSql = ({
offset?: number
}) => `
with materialized_views as (${MATERIALIZED_VIEWS_SQL({ schemaFilter, limit, offset, materializedViewIdentifierFilter, idsFilter })})
${includeColumns ? `, columns as (${COLUMNS_SQL({ schemaFilter, limit, offset, tableIdentifierFilter: materializedViewIdentifierFilter, tableIdFilter: idsFilter })})` : ''}
${includeColumns ? `, columns as (${COLUMNS_SQL({ schemaFilter, tableIdentifierFilter: materializedViewIdentifierFilter, tableIdFilter: idsFilter })})` : ''}
select
*
${
Expand Down
16 changes: 16 additions & 0 deletions test/server/materialized-views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,19 @@ test('materialized views with columns', async () => {
]
`)
})

test('materialized views with columns keep every column when listing with limit', async () => {
const { body } = await app.inject({
method: 'GET',
path: '/materialized-views',
query: { include_columns: 'true', limit: '1' },
})
const data = JSON.parse(body)
expect(data).toHaveLength(1)
expect(data[0].name).toBe('todos_matview')
expect(data[0].columns.map((column: { name: string }) => column.name)).toEqual([
'id',
'details',
'user-id',
])
})