fix: do not paginate columns when listing materialized views - #1115
Open
hsusul wants to merge 1 commit into
Open
fix: do not paginate columns when listing materialized views#1115hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
limit/offset apply to the matview CTE only, matching tables/views/foreign tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Why?
GET /materialized-views?include_columns=true&limit=Nforwardedlimit/offsetintoCOLUMNS_SQL. That paginates every column in the database, not columns of the selected matviews, so a limited list can return empty or truncatedcolumnsarrays.Tables, views, and foreign tables already paginate only the relation CTE.
Fixes #1113.
How?
Stop passing
limit/offsetinto the columns CTE ingenerateEnrichedMaterializedViewsSql.Checklist