Repository navigation
fix(musicbrainz): search a compilation's release as Various Artists - #64
Merged
suitux merged 1 commit intoOct 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #42, reported by @nielsha in #42 (comment).
The bulk MusicBrainz lookup prefilled the search with the most common album artist, or the track artist when that was empty. On a compilation without an album artist tag every track artist appears once, so the first track's artist won and the release search found nothing.
Now the artist is chosen like this:
feat.,ft.,&,x,with,vs.or a comma. If no artist appears on more than half of the songs, the search starts withVarious Artists, MusicBrainz' own name for compilations.Tested
helpers.test.tswith 7 new tests. All MusicBrainz tests pass (38), ESLint, Prettier and tsc are clean.release:"Bravo Hits 1" AND artist:"Various Artists"finds 2 releases, with the first track's artist (Madonna) 0. Same for "Now That's What I Call Music! 50": 7 releases versus 0 withRobbie Williams.