add a grid view of the journal - #1115
Open
vyagh wants to merge 1 commit into
Open
Conversation
Cards grouped by sitting in day bands. Hand-rolled layout: Gtk.FlowBox cannot break rows on group boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid View for the Journal:
Cards grouped by sitting, inside the same day bands as the list. Subclasses BaseJournalView from #1114, so query, selection and visibility match the list view. The toggle is the next PR for switching the views.
Builds on #1112 and #1114.
Design notes:
Testing: 112 journal tests pass, 21 new, all on the grouping logic. The drawing has no unit coverage; checked by eye in a live shell.
gridview.py is added to Makefile.am and POTFILES.in.