keep snaps and reflections out of the search index - #30
Open
vyagh wants to merge 1 commit into
Open
Conversation
Sugar's journal is getting a reflection feature (sugar PRs to follow). It stores three new metadata keys on an entry: moment-snap-N (base64 jpeg snapshots), reflections (the child's talk with an assistant) and next_steps (one line from that talk). None of these belong in the search index. The snapshots are about 1.5MB of base64 re-tokenized on every save, and indexing the talk made an entry match any word the assistant ever said. Entries without these keys are unaffected, so this lands safely on its own. The child's own title and description stay searchable.
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sugar journal is getting a reflection feature (sugar PRs to follow).
It stores 3 new metadata keys on an entry: moment-snap-N (base64 jpeg snapshots), reflections (the child's talk with an assistant) and next_steps (one line from that talk).
These don't belong in the search index. the snapshots are about 1.5MB of base64 retokenized on every save, and indexing the talk made an entry match any word the assistant ever said.
Entries without these keys are unaffected. child's own title and description stay searchable.