Repository navigation
fix(ssh): make SSH terminals part of the subshell experience - #341
Open
theogravity wants to merge 2 commits into
Open
theogravity wants to merge 2 commits into
theogravity wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH terminals now open through New subshell, alongside agents and ordinary terminals. The same choice is available when adding or splitting a workspace pane and when creating a workspace, so the SSH result stays in the requested context.
The form explains the destination and connecting machine, accepts typed destinations directly, and puts alternate key machines under Advanced SSH options. Key approval happens inside the dialog and returns to the same choices without automatically launching. Pending state covers both launch and workspace attachment. Saved destination management remains available in Settings → SSH.
The separate Connect navigation item is removed. Existing
/connectlinks redirect into the shared launcher with their choices preserved. Destination suggestions now dismiss after an outside click, avoiding a layout shift that swallowed clicks on controls below them.Stacked on #340. Validation: full tests, type checks, lint, prose and design checks, plus the web build. Browser coverage exercises New subshell → SSH, alternate keys, inline approval and retry; integration tests cover workspace selection and split attachment, including duplicate-launch prevention. Independent follow-up review reported zero MAJOR/MINOR findings.