Repository navigation
fix(ui): clarify selected tabs and segmented choices - #342
Open
theogravity wants to merge 2 commits into
Open
theogravity wants to merge 2 commits into
theogravity wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected tabs and segmented choices now use the same clear primary highlight throughout the web UI, including Terminal / Desktop App, settings tabs, workspace choices, and view switches. Choices retain their original icons; no selection checkmarks are added.
The shared Segmented component owns this treatment, replacing the SSH-only override. Keyboard focus and aria-pressed behavior remain intact. The design-system guidance records the new default.
Stacked on #341. Validation: full test suite, type checks, lint, prose/design checks, web build, and the isolated enrollment browser flow. Independent review reported zero MAJOR/MINOR findings.