Repository navigation
Split the local-attach WS suite (test parallel long pole) - #279
Merged
Merged
Conversation
…ed files The single file was the parallel run's long pole (26 s): under --parallel a file cannot be split across workers, so its wall clock is the package floor. Same 41 tests, shared fixture moved to helpers/local-attach-harness.ts, longest half now 10.7 s.
- the no-reflow-first cases live in the replay file, not the grid one; - drop the fake socket's subscribe/unsubscribe: the local path subscribes on the paneStreams registry, never on the socket, so the members were dead and their pubsub comment false (the HEAD fake never had them - keeping the move verbatim means a future ws.subscribe call should crash the suite, not be swallowed); - JSDoc the now-shared fixture members.
theogravity
force-pushed
the
feat/split-local-attach
branch
from
September 30, 2026 04:35
1d72a8a to
4a08c67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #277 (round 2 of issue #261).
subshell-ws-local-attach.test.tswas the server suite's single longest file (26.1 s, 1184 lines); under--parallelone file is one worker, so it set the package floor. Split into cleanup / grid / replay (41 tests preserved, measured 9.1/10.7/7.1 s) over a shared harness helper. Focused verification: 41/41 on the three files, fullbun run test51/51 green, verify-types + biome clean.