Repository navigation
M3: full screen keeps the page controls, with one toggle to hide them - #1734
Open
abdulrahmanelnegery wants to merge 1 commit into
Open
abdulrahmanelnegery wants to merge 1 commit into
abdulrahmanelnegery wants to merge 1 commit into
Conversation
…ne toggle hides them Full screen shows the quick tools and the page controls (page box, previous/next, zoom, fit, rotate, page display) each in its own island on the left, with a toggle above them that folds both away and brings them back from the same place. A full screen button sits in the title bar next to the theme button; Esc leaves full screen as before.
10 tasks done
7 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Full screen shows the quick tools and the page controls (page box, previous/next, zoom, fit, rotate, page display) each in its own floating island on the left, with a toggle above them that folds both away and brings them back from the same place. A full screen button sits in the title bar next to the theme button; Esc leaves full screen as before. Translated in every catalogue.
How you verified it
cargo fmt --check-D warningsonpdfcraft-ui-egui(all targets)cargo check --target wasm32-unknown-unknown -p pdfcraft-ui-eguiNew view test: the controls show in full screen, and one toggle hides and shows them and stays in the same place. On
maintoday two integration tests (dropping_a_pdf_on_the_window_opens_itintests/ui.rsanda_tool_chosen_with_no_document_asks_for_one_and_runs_on_itintests/commands.rs) are red in my environment with and without this change; #1681 addresses the second.Never-crash
unwrap/expect/panic!/unreachable!/todo!outside testsunsafeNo new asset, font or outbound network; nothing copied from another implementation.