Skip to content

M3: full screen keeps the page controls, with one toggle to hide them - #1734

Open
abdulrahmanelnegery wants to merge 1 commit into
storytold:mainfrom
abdulrahmanelnegery:contrib/fullscreen-controls
Open

abdulrahmanelnegery wants to merge 1 commit into
storytold:mainfrom
abdulrahmanelnegery:contrib/fullscreen-controls

Conversation

@abdulrahmanelnegery

Copy link
Copy Markdown

What this changes

Full screen shows the quick tools and the page controls (page box, previous/next, zoom, fit, rotate, page display) each in its own floating island on the left, with a toggle above them that folds both away and brings them back from the same place. A full screen button sits in the title bar next to the theme button; Esc leaves full screen as before. Translated in every catalogue.

How you verified it

  • cargo fmt --check
  • clippy with -D warnings on pdfcraft-ui-egui (all targets)
  • tests pass on the crate I changed
  • cargo check --target wasm32-unknown-unknown -p pdfcraft-ui-egui

New view test: the controls show in full screen, and one toggle hides and shows them and stays in the same place. On main today two integration tests (dropping_a_pdf_on_the_window_opens_it in tests/ui.rs and a_tool_chosen_with_no_document_asks_for_one_and_runs_on_it in tests/commands.rs) are red in my environment with and without this change; #1681 addresses the second.

Never-crash

  • No new unwrap/expect/panic!/unreachable!/todo! outside tests
  • No indexing or slicing with input-derived positions; checked or saturating arithmetic; allocations sized by input are capped; recursion is bounded
  • No unsafe

No new asset, font or outbound network; nothing copied from another implementation.

…ne toggle hides them

Full screen shows the quick tools and the page controls (page box, previous/next, zoom,
fit, rotate, page display) each in its own island on the left, with a toggle above them
that folds both away and brings them back from the same place. A full screen button sits in
the title bar next to the theme button; Esc leaves full screen as before.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant