Skip to content

i18n(pl): add Polish ribbon and dialog catalog - #1565

Closed
lukasz-sklad wants to merge 1 commit into
storytold:mainfrom
lukasz-sklad:i18n/polish-translation
Closed

lukasz-sklad wants to merge 1 commit into
storytold:mainfrom
lukasz-sklad:i18n/polish-translation

Conversation

@lukasz-sklad

Copy link
Copy Markdown

Add Polish (pl) translation covering ribbon tabs, Format Cells dialog, view options, alignment, formulas, and general dialog strings (514 entries). Locale tags resolving pl and pl-PL map to Language::Pl. Update docs/localization-parity.md.

Add Polish (pl) translation covering ribbon tabs, Format Cells dialog,
view options, alignment, formulas, and general dialog strings (514 entries).
Locale tags resolving pl and pl-PL map to Language::Pl.
Update docs/localization-parity.md.
@Harrison-Booth

Copy link
Copy Markdown
Contributor

Hi @lukasz-sklad, @brzuchal, @webglobepl: a heads-up from a housekeeping pass over the open PRs, so the Polish work doesn't get done twice.

Besides this PR, these open PRs also touch Polish translation:

What I checked: the open PR list of this repository today (titles, changed files, created and updated dates). I did not run or compare the catalogs themselves, so the overlap is by scope, not by line. pl.rs is already on main, so open PRs that add the catalog from scratch will conflict with it.

Could the authors agree between you on one PR to carry Polish (the others could then close, or be cut down to what the first one lacks)? Whichever you pick is fine; this isn't a ranking. The maintainers decide what merges.

For reference: the shared translation catalogs live in https://github.com/storytold/craft-i18n. GridCraft's own catalogs haven't moved there yet, so for now interface translations still go in this repository (crates/ui-egui/src/i18n/).

@webglobepl

Copy link
Copy Markdown
Contributor

Thanks for the heads-up, @Harrison-Booth!

I'd suggest my PRs carry Polish:

@lukasz-sklad, @brzuchal: if your PRs have translations that #2391 or #1883 miss, point me to them and I'll fold them in, with credit in contributors/people.toml. Of course the maintainers have the final word.

@lukasz-sklad

Copy link
Copy Markdown
Author

Hi @webglobepl, @Harrison-Booth! Sounds great, thank you for organizing this. Feel free to incorporate any missing translations from my PR into yours, so we have one complete and consistent Polish translation for GridCraft. Much appreciated for including me in contributors/people.toml (@lukasz-sklad). Cheers!

@webglobepl

Copy link
Copy Markdown
Contributor

Thanks, @lukasz-sklad! I compared the catalogs: all 443 keys from #1565 are already in #2391, so no translation is missing. 69 of them are worded differently. In #2391 I kept the wording of the Polish Excel ribbon (e.g. „Zapis dziesiętny”, „Zwiększ dziesiętne”, „Obramowania”), so the labels match what Polish Excel users already know.

One correction about the credit: contributors/people.toml asks everyone to add only their own entry, in their own PR, so I can't add you there myself. Your entry from #1565 ([people.lukasz-sklad]) can go in as a small PR of your own. Sorry for promising something I couldn't do!

@lukasz-sklad

Copy link
Copy Markdown
Author

Thanks for checking and for the explanation, @webglobepl! That makes complete sense. Feel free to proceed with #2391 then, I'll close this PR to keep the tracker clean. Good luck with the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants