Repository navigation
i18n: catalogs list each source once again - #2627
Merged
Merged
Conversation
…stered #2054's own merge of main re-added zh-hans/zh-hant rows that main already had, so catalogs_are_unique_and_keep_the_english_shape failed on main. The catalog is the batch-tested one, with ('ka', GEORGIAN_PANELS) back in ROWS (the batch's merge helper had folded it into the first 'ka' entry). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
i18n::ui::tests::catalogs_are_unique_and_keep_the_english_shapefails after batch Q: #2054's own merge ofmainre-added Simplified/Traditional Chinese rows that main already had.crates/ui-egui/src/i18n/ui.rsis now the batch-tested catalog: each source once, with #1514's tool names, #2427's Preview labels, #1581's and #2054's rows and #1340's Polish.("ka", GEORGIAN_PANELS)is back inROWS; the batch's catalog-merge helper had wrongly folded it into the first"ka"entry. The i18n unit tests pass.🤖 Generated with Claude Code