Repository navigation
Fix incomplete system font coverage in the Chinese interface - #1973
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Contributor
|
This is in integration batch #2257, with a small follow-up: catalog characters in a block that already found no face are skipped, so a machine without a covering font doesn't re-read every font file per block. |
aiongg
added a commit
that referenced
this pull request
Oct 23, 2026
…ready found no face (#1973) On a machine with no font covering the catalog, each uncovered 256-character block re-read every installed font file on the UI thread; blocks that already failed are skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to Simplified Chinese can still draw labels as replacement boxes when the system face
chosen by the single Han probe covers only a subset of the catalog. Register additional unique
fallback faces for the actual catalog characters, keeping the original CJK ordering and every UI
font family. No font assets are added.
The existing Simplified Chinese regression failed before this change and passes with catalog-based
fallback coverage. No locale tests are filtered.
This package is independent of mask editing changes.
Validation:
CARGO_PROFILE_RELEASE_LTO=off cargo xtask ci(format, release Clippy with warnings denied, complete releaseworkspace tests, dependency/layer/asset checks and WASM compilation). Native interaction validation
was performed on macOS; Windows/Linux native interaction has not been checked locally.
No dependency or project schema changes. No third-party media assets are added.
LTO is disabled only for local validation to reduce test-executable link time. No tests or gate
phases are excluded, and repository release settings are unchanged.
Local gate result: 3,667 passed, zero failed, 31 ignored across 199 test suites; all gate phases completed.
Summary by CodeRabbit