Repository navigation
test(engine): guard the Unix-only importer fixture - #1889
Open
TimotheusG wants to merge 2 commits into
Open
TimotheusG wants to merge 2 commits into
TimotheusG wants to merge 2 commits into
Conversation
This was referenced Oct 19, 2026
This was referenced Oct 19, 2026
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stillsis used only by the Unix-specific part of the document-path test, but its declaration andImporterimplementation were compiled on Windows too. Strict Clippy therefore failed withdead_codebefore reaching the tests.Apply the same
#[cfg(unix)]guard to both. No runtime code or test assertions change. This extracts the two-line supporting fix already present in #1827 so it can land independently of the audio work.Companion fixes: socket write cancellation (#1891) and host-independent font tests (#1890).
Validation on Windows x64 (release, LTO disabled and 16 codegen units):
cargo xtask cipassed with all three maintenance fixes applied together: 3,657 tests passed, 32 existing opt-in tests ignored; format, strict Clippy, dependency/layer/asset audits and all 32 wasm crate checks passed.theme::script_font_tests::simplified_chinese_interface_draws_simplified_hanzi_after_another_languagefailure. The identical failure was reproduced in the pre-change UI test binary (run 23 with--test-threads=64). Five complete UI runs with this patch passed, followed by the successful full CI rerun. This separate intermittent issue remains unresolved; no test was disabled to get the passing run.Summary by CodeRabbit