Skip to content

test(engine): guard the Unix-only importer fixture - #1889

Open
TimotheusG wants to merge 2 commits into
storytold:mainfrom
TimotheusG:fix/unix-test-helper-cfg
Open

TimotheusG wants to merge 2 commits into
storytold:mainfrom
TimotheusG:fix/unix-test-helper-cfg

Conversation

@TimotheusG

@TimotheusG TimotheusG commented Oct 19, 2026 •

Copy link
Copy Markdown

Stills is used only by the Unix-specific part of the document-path test, but its declaration and Importer implementation were compiled on Windows too. Strict Clippy therefore failed with dead_code before reaching the tests.

Apply the same #[cfg(unix)] guard to both. No runtime code or test assertions change. This extracts the two-line supporting fix already present in #1827 so it can land independently of the audio work.

Companion fixes: socket write cancellation (#1891) and host-independent font tests (#1890).

Validation on Windows x64 (release, LTO disabled and 16 codegen units):

  • cargo xtask ci passed with all three maintenance fixes applied together: 3,657 tests passed, 32 existing opt-in tests ignored; format, strict Clippy, dependency/layer/asset audits and all 32 wasm crate checks passed.
  • The independent branches retain the failures addressed by their companion PRs; the full-CI result is for their combination.
  • An earlier run hit the existing intermittent theme::script_font_tests::simplified_chinese_interface_draws_simplified_hanzi_after_another_language failure. The identical failure was reproduced in the pre-change UI test binary (run 23 with --test-threads=64). Five complete UI runs with this patch passed, followed by the successful full CI rerun. This separate intermittent issue remains unresolved; no test was disabled to get the passing run.

Summary by CodeRabbit

  • Tests
    • Limited the relevant test support and its associated tests to Unix platforms. These tests and components are no longer compiled on non-Unix platforms.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0659446d-10f9-41a6-9802-64998d3d1e24
📥 Commits

Reviewing files that changed from the base of the PR and between 98eadff and 4ba53e7.

📒 Files selected for processing: 1
  • crates/engine/src/doc_path/tests.rs
🚧 Files skipped from review as they are similar to previous changes: 1
  • crates/engine/src/doc_path/tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The Stills test fixture and its Importer implementation are now compiled only on Unix. A doc comment describes how the probe treats test files.

Changes: Unix test fixture

Layer / File(s) Summary
Gate the test fixture to Unix
crates/engine/src/doc_path/tests.rs
The Stills fixture and its Importer implementation are gated to Unix. A doc comment describes how the probe treats test files.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: bflatastic

Merge Risk: ⚪ Minimal · up to 4ba53

This change only affects which test helpers compile on non-Unix platforms. It does not change product behavior and carries no merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: guarding the Unix-only importer fixture in engine tests.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution timed out

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant